Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add incr api #28

Merged
merged 5 commits into from
Apr 18, 2024
Merged

feat: add incr api #28

merged 5 commits into from
Apr 18, 2024

Conversation

rishtigupta
Copy link
Contributor

@rishtigupta rishtigupta commented Apr 16, 2024

PR Description:

  • Add INCR api support.
    Note: We are only supporting incr operation for when non-compression client is used, and emitting an error when a compression client is used.

Testing

  • Integration Testing done separately for increment when compression client is used vs non-compression client is used

Issue:

https://github.com/momentohq/dev-eco-issue-tracker/issues/784

@rishtigupta rishtigupta marked this pull request as ready for review April 16, 2024 23:28
@rishtigupta rishtigupta requested review from cprice404 and a team April 16, 2024 23:28
src/momento-redis-adapter.ts Outdated Show resolved Hide resolved
test/increment-compression.test.ts Outdated Show resolved Hide resolved
@rishtigupta rishtigupta merged commit 8f34f5c into main Apr 18, 2024
12 checks passed
@rishtigupta rishtigupta deleted the feat/add-incr branch April 18, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants