chore: use getBatch/setbatch for mget/mset #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cprice404
reviewed
Apr 19, 2024
test/multiple-set-get.test.ts
Outdated
| if (process.env.MOMENTO_ENABLED === 'true') { | ||
| expect(getResp).toEqual([value]); | ||
| } else { | ||
| expect(getResp).toEqual([value, null]); |
There was a problem hiding this comment.
this feels wrong to me. I think we should be able to return the same result that redis does here. Can you help me understand why we can't?
There was a problem hiding this comment.
Because GetBatch Response from sdk returns a map/record of keys and values for only the keys that exist.
There was a problem hiding this comment.
There was a problem hiding this comment.
it also exposes a results function to get the raw results. But even with the map/record versions, you have the list of keys that they asked for, in the order that they asked for them, so you could just add nulls into the return value for anything that didn't show up in the map, right?
cprice404
reviewed
Apr 19, 2024
cprice404
reviewed
Apr 22, 2024
cprice404
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
Follow-up PR for #29. This commit does the following:
Note
The Momento GetBatch operation returns a record or map containing only the keys for which values exist. It does not include keys that do not exist in the cache. Hence, validating the null case for Momento and Redis separately in the integ tests.
Issue:
https://github.com/momentohq/dev-eco-issue-tracker/issues/789