Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: The URL to info about README generation was broken. #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: The URL to info about README generation was broken. #37

wants to merge 1 commit into from

Conversation

schwern
Copy link
Contributor

@schwern schwern commented Dec 1, 2022 

Error: README template does not conform to Momento OSS requirements:
{"lineNumber":45,"ruleNames":["expected-sdk-section-headers"],"ruleDescription":"SDK must have required section headers","ruleInformation":"https://github.com/momentohq/standards-and-practices/github-actions/oss-readme-generator","errorDetail":"After header 'Requirements', missing expected header: 'Examples'","errorContext":null,"errorRange":null,"fixInfo":null}

That link is broken.

@schwern schwern added the bug Something isn't working label Dec 1, 2022
cprice404
cprice404 approved these changes Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:ty:

@schwern
Copy link
Contributor Author

schwern commented Dec 1, 2022

No idea what's going on with the failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cprice404 cprice404 cprice404 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schwern @cprice404