-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move util functions out of cgaz.js #107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeenScreeker
added
Size: Small
Something that may take a day at most to do.
Type: Development / Internal
Something that is more internal to development than end-user.
labels
Nov 28, 2023
tsa96
requested changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these are global utilities now, we should absolutely get them over to TypeScript. I've done colors.ts
for you, math.ts
should be very easy.
PeenScreeker
force-pushed
the
feat/cgaz-math-utils
branch
4 times, most recently
from
December 2, 2023 03:46
4829df5
to
16bcaa1
Compare
tsa96
reviewed
Dec 2, 2023
PeenScreeker
force-pushed
the
feat/cgaz-math-utils
branch
from
December 2, 2023 04:29
16bcaa1
to
128364e
Compare
tsa96
requested changes
Dec 2, 2023
PeenScreeker
force-pushed
the
feat/cgaz-math-utils
branch
from
December 2, 2023 20:12
128364e
to
0cee3fe
Compare
tsa96
requested changes
Dec 2, 2023
tsa96
approved these changes
Dec 12, 2023
tsa96
force-pushed
the
feat/cgaz-math-utils
branch
from
January 17, 2024 17:33
0cee3fe
to
05e475c
Compare
Sorry didn't realise I hadn't resolved everything |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Size: Small
Something that may take a day at most to do.
Type: Development / Internal
Something that is more internal to development than end-user.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves math functions out of the cgaz.js file to separate util files
math.js
andcolors.js
. The intent is to move these out for:Upon merging this PR, cgaz.js should be broken up into separate tools. It seemed appropriate to break this into two separate pull requests to keep the refactor organized.
Checks
feat: Add foo
,chore: Update bar
, etc...fixup
ed into my original commits.