-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check for invalid speedometer names #110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also, do I just need to supply the tokenized string or do I need to actually add it somewhere? |
No just the token and string, whoever approves it will add it to POEditor (requires POEditor admin) |
Looks good. @Gocnak I've added the string to POEditor already, merge when you're happy! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, good stuff
Deleting a speedometer with the same name as an existing speedometer results in an
underlying object
js exception. This is becausethis.detailObject.findIndex()
insidedeleteSpeedometer()
deletes the first speedometer matching the name of the selected speedometer. I have changedspeedometer-select.js
to check for these invalid names (mostly used the same code from range-color-profile-name.js). This also makes it consistent with deleting and adding range profiles.Checks
feat: Add foo
,chore: Update bar
, etc...fixup
ed into my original commits.POEditor JSON Strings (if needed)