0.10 Map Selector Part 1 #157
Open
+994
−933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dunno what's up with ESLint will fix tomorrow |
tsa96
force-pushed
the
refactor/0.10-map-selector
branch
from
f553386
to
87ce2ae
Compare
I miss Tailwind
Thanks SCell!!
Looks bad, also Pano can capitalize in CSS if needed, stupid (me) doing it in JS
Peen you've probs fixed this already and this'll probs conflict with your stuff, just overwrite.
Wanted the iterator method thingies
Yaaaaay we have to do submodule bumps for P2:CE-only stuff :)
tsa96
force-pushed
the
refactor/0.10-map-selector
branch
from
87ce2ae
to
e5eb305
Compare
This might conflict with some of rio's map-info/tab-menu/loading-screen stuff, tried to make minimal changes here. Moved some MapEntry logic from C++ to TS in the process, fewer hardcoded values in C++.
tsa96
force-pushed
the
refactor/0.10-map-selector
branch
from
78d36f4
to
05fe373
Compare
Gocnak
reviewed
Nov 20, 2024
Comment on lines
+5
to
+6
| const DASHBOARD_URL = 'https://dashboard.momentum-mod.org'; | ||
|
|
There was a problem hiding this comment.
Should this move to a convar as well? Staging dashboard vs main site dashboard will be different URLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the Panorama changes corresponding to #2345 on red. Some UI tweaks as well though still slightly WIP, want to get a PR in at a stable point corresponding to the incoming changes on red.
I'll have a subsequent branch on red and here open ASAP, C++ side of that is mostly finished.
Checks
feat: Add foo,chore: Update bar, etc...fixuped into my original commits.POEditor JSON Strings (if needed)
Made some POEditor additions recently but just added them directly.