Native TypeScript Compilation #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shegetz
reviewed
Nov 16, 2024
|
|
||
| #### Recommendations | ||
| Most of our larger systems and components require significant work with (closed-source) game code and thus requires |
There was a problem hiding this comment.
comma before "and" / "require" instead of "requires"
|
|
||
| #### Recommendations | ||
| Most of our larger systems and components require significant work with (closed-source) game code and thus requires | ||
| licensed C++ access or working tandem licensed C++ developer. Our work until now has been done internally by the core |
There was a problem hiding this comment.
"working in tandem with a" instead of "working tandem"
Gocnak
approved these changes
Nov 20, 2024
|
|
||
| `npm install` | ||
| ### Type checking, Linting and Formatting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes build setup and XML includes to use new native TypeScript support
Shoutout to SCell