🐛 Include query prop checksums in execution checksum (#1367)

mondoohq · Jul 15, 2024 · 3efe9a3 · 3efe9a3
1 parent c3d3224
commit 3efe9a3
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/policy/policy.go b/policy/policy.go
@@ -480,6 +480,10 @@ func (p *Policy) updateAllChecksums(ctx context.Context,
 			if err != nil {
 				return err
 			}
+
+			for _, p := range check.Props {
+				executionChecksum = executionChecksum.Add(p.Checksum)
+			}
 		}
 
 		// DATA (must be sorted)
@@ -521,6 +525,10 @@ func (p *Policy) updateAllChecksums(ctx context.Context,
 			if err != nil {
 				return err
 			}
+
+			for _, p := range query.Props {
+				executionChecksum = executionChecksum.Add(p.Checksum)
+			}
 		}
 
 		// FILTERs (also sorted)

diff --git a/policy/policy_test.go b/policy/policy_test.go
@@ -211,6 +211,14 @@ func TestPolicyChecksums(t *testing.T) {
 					// effective if the query is taking the mql bits from its base.
 					b.Queries[0].CodeId = "12345"
 				},
+				"query prop changed": func() {
+					b.Queries[0].Props = []*explorer.Property{
+						{
+							Mql:      "1 == 1",
+							Checksum: "1234",
+						},
+					}
+				},
 				"mrn changed": func() {
 					p.Mrn = "normal mrn"
 				},