Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes to AddSpecdScore #1362

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

jaym
Copy link
Contributor

@jaym jaym commented Jul 9, 2024

Not all calculators handle ignoring score properly. That code is still needed

Not all calculators handle ignoring score properly. That code is still
needed
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Test Results

  1 files  ±0   24 suites  ±0   18s ⏱️ -1s
385 tests ±0  384 ✅ ±0  1 💤 ±0  0 ❌ ±0 
386 runs  ±0  385 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit f09c7e4. ± Comparison against base commit 8a40273.

@imilchev imilchev merged commit 905c6f7 into main Jul 9, 2024
13 checks passed
@imilchev imilchev deleted the jdm/revert-ignore-score-changes branch July 9, 2024 17:13
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants