Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐️ replace dque with pdque #951

Merged
merged 22 commits into from
Nov 23, 2023
Merged

⭐️ replace dque with pdque #951

merged 22 commits into from
Nov 23, 2023

Conversation

mariuskimmina
Copy link
Contributor

@mariuskimmina mariuskimmina commented Nov 16, 2023

@mariuskimmina mariuskimmina marked this pull request as draft November 16, 2023 10:38
policy/scan/disk_queue_test.go Show resolved Hide resolved
policy/scan/disk_queue_test.go Outdated Show resolved Hide resolved
policy/scan/disk_queue_test.go Outdated Show resolved Hide resolved
policy/scan/pdque/queue_test.go Outdated Show resolved Hide resolved
policy/scan/pdque/queue_test.go Show resolved Hide resolved
@mariuskimmina mariuskimmina marked this pull request as ready for review November 17, 2023 15:51
Copy link
Member

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things remaining, very close!

policy/scan/pdque/queue.go Outdated Show resolved Hide resolved
policy/scan/pdque/queue.go Show resolved Hide resolved
policy/scan/pdque/queue.go Outdated Show resolved Hide resolved
policy/scan/pdque/queue.go Show resolved Hide resolved
Copy link
Member

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates + implementation @mariuskimmina !!
kudos for the review @imilchev 😁

@arlimus arlimus merged commit ce1a460 into main Nov 23, 2023
9 checks passed
@arlimus arlimus deleted the marius/switch-to-pdque branch November 23, 2023 23:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scan API keeps crashing because of corrupted queue file
3 participants