Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors in PREview notifications #3

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix errors in PREview notifications #3

merged 1 commit into from
Feb 29, 2024

Conversation

benr
Copy link
Member

@benr benr commented Feb 29, 2024 •
edited
Loading

Description

This change:

  1. Removes unused argments to the PR Comment steps
  2. Changes the PREview environment creation message to '... created' rather than '... ready' to be a bit more clear that the environment is prepared but the content hasn't be staged yet.

Related issue

Types of changes

  • Functional documentation bug fix (i.e., broken link or some other busted behavior)
  • New functional doc capabilities (i.e., filter search results)
  • New content
  • Revision to existing content
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist

  • I have read the README document about contributing to this repo.
  • I have tested my changes locally and there are no issues.
  • All commits are signed.

@benr benr self-assigned this Feb 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Starting creation of the PREview environment...

@github-actions GitHub Actions
Copy link
Contributor

PREview environment has been created at https://mondoo-pre-docs-preview-ready.storage.googleapis.com/docs/index.html

@github-actions GitHub Actions
Copy link
Contributor

PREview has been updated at https://mondoo-pre-docs-preview-ready.storage.googleapis.com/docs/index.html

@misterpantz misterpantz merged commit 6b104df into main Feb 29, 2024
9 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Cleaning up PREview environment...

@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
@tas50 tas50 deleted the benr/preview-ready branch September 6, 2024 22:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@misterpantz misterpantz misterpantz approved these changes

Assignees

@benr benr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benr @misterpantz