Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail builds when an anchor link is bad #395

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

tas50
Copy link
Member

@tas50 tas50 commented Oct 3, 2024

Description

We get warnings right now, but we don't see them. Let's fail the build hard

Related issue

Types of changes

  • Functional documentation bug fix (i.e., broken link or some other busted behavior)
  • New functional doc capabilities (i.e., filter search results)
  • New content
  • Revision to existing content
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist

  • I have read the README document about contributing to this repo.
  • I have tested my changes locally and there are no issues.
  • All commits are signed.

We get warnings right now, but we don't see them. Let's fail the build
hard

Signed-off-by: Tim Smith <[email protected]>
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Starting creation of the PREview environment...

Copy link
Contributor

@misterpantz misterpantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic!

Copy link
Contributor

github-actions bot commented Oct 3, 2024

PREview environment has been created at https://mondoo-pre-docs-1289125860.storage.googleapis.com/docs/index.html
Please allow a few minutes for the environment to be fully deployed.

@misterpantz misterpantz merged commit 8fc2c42 into main Oct 3, 2024
6 checks passed
@misterpantz misterpantz deleted the tas50/build_fails branch October 3, 2024 20:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants