Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure state compatibility with v1 #15

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

johnletey
Copy link
Contributor

@johnletey johnletey commented Oct 18, 2024

This PR addresses state compatibility issues when upgrading the Florin module from v1 to v2

The underlying issue was that collections.Pair inserts an extra delimiter byte to distinguish between the two keys. However, with the manual state management included in v1, we simply concatenated the two keys together.

We've used the latest commit on this branch to patch a Noble testnet node, and can confirm it is working as expected:

Screenshot 2024-10-18 at 13 57 18

@johnletey johnletey marked this pull request as ready for review October 18, 2024 13:56
@gislik gislik merged commit 8ef40ef into monerium:main Oct 18, 2024
1 check passed
@johnletey johnletey deleted the state-compatibility branch October 18, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants