epee: use std::filesystem::file_size to implement get_file_size
#9514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ils::get_file_size` Fixes monero-project#9513
vtnerd
suggested changes
Oct 11, 2024
| } | ||
| #endif | ||
| std::error_code ec; | ||
| size = static_cast<uint64_t>(std::filesystem::file_size(path_to_file, ec)); |
There was a problem hiding this comment.
How many places is this called? Should we change uint64_t to std::uintmax_t here?
There was a problem hiding this comment.
It would only really matter if we care about getting the size of a file bigger than 18 million terabytes. I think we're safe for a while...
There was a problem hiding this comment.
But to be fair, it's only used in two places so it might be cleaner to just remove the epee wrapper altogether.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9513