Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUST-1130 Version 2.1.0 silently broke wasm builds with uuid #334

Open
ilslv opened this issue Dec 15, 2021 · 3 comments
Open

RUST-1130 Version 2.1.0 silently broke wasm builds with uuid #334

ilslv opened this issue Dec 15, 2021 · 3 comments
Labels
tracked-in-jira Ticket filed in Mongo's Jira system

Comments

@ilslv
Copy link

ilslv commented Dec 15, 2021

Version 2.1.0 enables uuids v4 feature, which seems to be a breaking change, as juniper wasm build began failing today.

@patrickfreed
Copy link
Contributor

Hi @ilslv, thanks for reporting this issue! I can confirm that, by default, bson 2.1.0 doesn't build on wasm. It does appear that downstream crates can work around this for now by adding an explicit dependency on uuid with the wasm-bindgen feature flag enabled. I've also filed RUST-1130 to discuss with the team options for improving this on our end. Please let me know if the workaround works for you or if you have any more questions, thanks!

@ilslv
Copy link
Author

ilslv commented Dec 16, 2021

Thanks for the workaround!
Maybe we can add wasm-bindgen feature for uuid based on target right in this repo and also add wasm build on the CI? I'll be happy to contribute this.

@bajanam bajanam changed the title Version 2.1.0 silently broke wasm builds with uuid RUST-1130 t Version 2.1.0 silently broke wasm builds with uuid Feb 22, 2022
@bajanam bajanam changed the title RUST-1130 t Version 2.1.0 silently broke wasm builds with uuid RUST-1130 Version 2.1.0 silently broke wasm builds with uuid Feb 22, 2022
@patrickfreed
Copy link
Contributor

Yeah, we plan on doing something like that, and thanks for offering to contribute those changes @ilslv! Since our CI system is built in-house and is somewhat tricky to configure, we usually handle doing stuff like that ourselves though. That said, we plan to get to RUST-1130 sometime over the next quarter, so stay tuned for updates! In the meantime, I hope the above workaround works sufficiently well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracked-in-jira Ticket filed in Mongo's Jira system
Projects
None yet
Development

No branches or pull requests

3 participants