DOCSP-43072: GridFS #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mongoKart
requested changes
Oct 1, 2024
source/write/gridfs.txt
Outdated
Comment on lines
63
to
64
| View the following diagram to see how GridFS splits the files when uploaded to | ||
| a bucket: |
There was a problem hiding this comment.
S:
Suggested change
| View the following diagram to see how GridFS splits the files when uploaded to | |
| a bucket: | |
| The following diagram shows how GridFS splits files when they are | |
| uploaded to a bucket: |
norareidy
commented
Oct 1, 2024
source/includes/write/gridfs.c
Outdated
Comment on lines
91
to
95
| bson_oid_t oid; | ||
| bson_oid_init_from_string (&oid, "66fb1b8ea0f84a74ee099e71"); | ||
| bson_value_t file_id; | ||
| file_id.value_type = BSON_TYPE_OID; | ||
| memcpy(&file_id.value.v_oid, &oid, sizeof(bson_oid_t)); |
There was a problem hiding this comment.
Note to tech reviewer: this seems like an overly complicated way to pass a file ID, so let me know if there's a better way (same with the next example)
There was a problem hiding this comment.
Should be valid to omit the temporary oid:
Suggested change
| bson_oid_t oid; | |
| bson_oid_init_from_string (&oid, "66fb1b8ea0f84a74ee099e71"); | |
| bson_value_t file_id; | |
| file_id.value_type = BSON_TYPE_OID; | |
| memcpy(&file_id.value.v_oid, &oid, sizeof(bson_oid_t)); | |
| bson_value_t file_id; | |
| file_id.value_type = BSON_TYPE_OID; | |
| bson_oid_init_from_string (&file_id.value.v_oid, "66fb1b8ea0f84a74ee099e71"); |
(Same suggestion on other occurrences.)
kevinAlbs
requested review from
vector-of-bool
and removed request for
kevinAlbs
|
Hi @vector-of-bool, just bumping this last PR review for the C standardization epic! |
vector-of-bool
approved these changes
Oct 10, 2024
source/includes/write/gridfs.c
Outdated
Comment on lines
91
to
95
| bson_oid_t oid; | ||
| bson_oid_init_from_string (&oid, "66fb1b8ea0f84a74ee099e71"); | ||
| bson_value_t file_id; | ||
| file_id.value_type = BSON_TYPE_OID; | ||
| memcpy(&file_id.value.v_oid, &oid, sizeof(bson_oid_t)); |
There was a problem hiding this comment.
Should be valid to omit the temporary oid:
Suggested change
| bson_oid_t oid; | |
| bson_oid_init_from_string (&oid, "66fb1b8ea0f84a74ee099e71"); | |
| bson_value_t file_id; | |
| file_id.value_type = BSON_TYPE_OID; | |
| memcpy(&file_id.value.v_oid, &oid, sizeof(bson_oid_t)); | |
| bson_value_t file_id; | |
| file_id.value_type = BSON_TYPE_OID; | |
| bson_oid_init_from_string (&file_id.value.v_oid, "66fb1b8ea0f84a74ee099e71"); |
(Same suggestion on other occurrences.)
source/includes/write/gridfs.c
Outdated
Comment on lines
29
to
30
| bson_t opts; | ||
| bson_init(&opts); |
There was a problem hiding this comment.
Prefer BSON_INITIALIZER
Suggested change
| bson_t opts; | |
| bson_init(&opts); | |
| bson_t opts = BSON_INITIALIZER; |
source/includes/write/gridfs.c
Outdated
Comment on lines
45
to
49
| if (upload_stream == NULL) { | ||
| fprintf (stderr, "Failed to create upload stream: %s\n", error.message); | ||
| } | ||
| const char *data = "Data to store"; | ||
| mongoc_stream_write (upload_stream, data, strlen(data), -1); |
There was a problem hiding this comment.
Minor: Should not try to use the stream on failure.
Suggested change
| if (upload_stream == NULL) { | |
| fprintf (stderr, "Failed to create upload stream: %s\n", error.message); | |
| } | |
| const char *data = "Data to store"; | |
| mongoc_stream_write (upload_stream, data, strlen(data), -1); | |
| if (upload_stream == NULL) { | |
| fprintf (stderr, "Failed to create upload stream: %s\n", error.message); | |
| } else { | |
| const char *data = "Data to store"; | |
| mongoc_stream_write (upload_stream, data, strlen(data), -1); | |
| } |
Or show the example aborting/goto fail/etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-43072
Staging - https://deploy-preview-60--docs-c.netlify.app/write/gridfs/
Self-Review Checklist