Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-34044: Add bitwise operators to aggregation pipeline #253

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

DOCSP-34044: Add bitwise operators to aggregation pipeline #253

wants to merge 18 commits into from
+222 −5

Conversation

mayaraman19
Copy link
Collaborator

@mayaraman19 mayaraman19 commented Oct 14, 2024 •
edited by github-actions bot
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-34044

Staging Links

  • fundamentals/linq

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    @netlify Netlify
    Copy link

    netlify bot commented Oct 14, 2024 •
    edited
    Loading

    ✅ Deploy Preview for mongodb-docs-csharp ready!

    Name Link
    🔨 Latest commit 45e9f9c
    🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/671026dde4f8d700084efd65
    😎 Deploy Preview https://deploy-preview-253--mongodb-docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @mayaraman19 mayaraman19 marked this pull request as ready for review October 15, 2024 18:50
    @mayaraman19 mayaraman19 changed the title Docsp 34044 bitwise DOCSP-34044: Add bitwise operators to aggregation pipeline Oct 15, 2024
    rustagir
    rustagir requested changes Oct 15, 2024
    View reviewed changes
    Copy link
    Collaborator

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Leaving a first batch of comments so that you can propagate these changes to the other sections. Please lmk if you have questions baout any of my feedback!

    source/fundamentals/linq.txt Outdated Show resolved Hide resolved
    source/fundamentals/linq.txt Outdated Show resolved Hide resolved
    source/fundamentals/linq.txt Outdated Show resolved Hide resolved
    source/fundamentals/linq.txt Outdated Show resolved Hide resolved
    source/fundamentals/linq.txt Outdated Show resolved Hide resolved
    source/fundamentals/linq.txt Outdated Show resolved Hide resolved
    source/fundamentals/linq.txt Outdated Show resolved Hide resolved
    source/fundamentals/linq.txt Outdated Show resolved Hide resolved
    source/fundamentals/linq.txt Outdated Show resolved Hide resolved
    rustagir
    rustagir requested changes Oct 16, 2024
    View reviewed changes
    Copy link
    Collaborator

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    a few more small suggestions!

    source/fundamentals/linq.txt Outdated Show resolved Hide resolved
    source/fundamentals/linq.txt Outdated Show resolved Hide resolved
    source/fundamentals/linq.txt Outdated Show resolved Hide resolved
    source/fundamentals/linq.txt Outdated Show resolved Hide resolved
    source/fundamentals/linq.txt Outdated Show resolved Hide resolved
    rustagir
    rustagir approved these changes Oct 16, 2024
    View reviewed changes
    Copy link
    Collaborator

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    good job!! just a few nits

    source/fundamentals/linq.txt Outdated Show resolved Hide resolved
    source/fundamentals/linq.txt Outdated Show resolved Hide resolved
    source/fundamentals/linq.txt Outdated Show resolved Hide resolved
    @mayaraman19 mayaraman19 requested review from a team and sanych-sun and removed request for a team October 16, 2024 20:54
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @rustagir rustagir rustagir approved these changes

    @sanych-sun sanych-sun Awaiting requested review from sanych-sun sanych-sun was automatically assigned from mongodb/dbx-csharp-dotnet

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @mayaraman19 @rustagir