Add improved Bulk Write API for Java Reactive Driver #1583

vbabanin · 2024-12-13T01:31:01Z

Created and documented the new Reactive Bulk Write API
Enabled unified and prose tests for reactive Bulk Write API

- Created and documented the new Reactive Bulk Write API - Enabled unified and prose tests for reactive Bulk Write API JAVA-5530

JAVA-5530

vbabanin · 2024-12-14T03:35:27Z

...e/src/integration/kotlin/com/mongodb/kotlin/client/coroutine/syncadapter/SyncMongoCluster.kt

-        org.junit.jupiter.api.Assumptions.assumeTrue(java.lang.Boolean.parseBoolean(toString()), "BULK-TODO implement")
-        TODO("BULK-TODO implement")
+        org.junit.jupiter.api.Assumptions.assumeTrue(
+            java.lang.Boolean.parseBoolean(toString()), "BULK-TODO Kotlin implement")


I have updated the naming to specifically ignore Kotlin tests in the UnifiedTestRunner to ensure that only these tests are skipped on assumption errors until the Kotlin API is implemented.

JAVA-5530

stIncMale

Reviewed everything except for

ClientBulkWriteOperation.java
CursorHelper.java
AsyncFunctionsAbstractTest.java

The last reviewed commit: 9a7d9ba.

driver-core/src/main/com/mongodb/internal/async/AsyncFunction.java

driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTestModifications.java

...c/test/functional/com/mongodb/reactivestreams/client/unified/UnifiedReactiveStreamsTest.java

driver-sync/src/test/functional/com/mongodb/client/CrudProseTest.java

...ve-streams/src/main/com/mongodb/reactivestreams/client/internal/MongoOperationPublisher.java

driver-core/src/main/com/mongodb/internal/async/AsyncSupplier.java

driver-core/src/main/com/mongodb/internal/async/AsyncRunnable.java

driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTestModifications.java

…st.java Co-authored-by: Valentin Kovalenko <[email protected]>

Co-authored-by: Valentin Kovalenko <[email protected]>

…lient/MongoCluster.java Co-authored-by: Valentin Kovalenko <[email protected]>

…java Co-authored-by: Valentin Kovalenko <[email protected]>

Co-authored-by: Valentin Kovalenko <[email protected]>

Remove redundant methods. JAVA-5530

JAVA-5530

driver-core/src/test/unit/com/mongodb/internal/async/AsyncFunctionsAbstractTest.java

driver-core/src/main/com/mongodb/internal/operation/CursorHelper.java

driver-core/src/main/com/mongodb/internal/operation/ClientBulkWriteOperation.java

stIncMale · 2024-12-17T01:27:40Z

driver-core/src/main/com/mongodb/internal/operation/ClientBulkWriteOperation.java

    /**
     * To execute a batch means:
     * <ul>
     *     <li>execute a `bulkWrite` command, which creates a cursor;</li>
     *     <li>consume the cursor, which may involve executing `getMore` commands.</li>
     * </ul>
     *
-     * @throws MongoException When a {@linkplain ClientBulkWriteException#getError() top-level error} happens.
+     * @throws MongoException When a {@linkplain ClientBulkWriteException#getCause() top-level error} happens.


Thank you! I missed this when I refactored out ClientBulkWriteException.getError.

driver-core/src/main/com/mongodb/internal/operation/ClientBulkWriteOperation.java

JAVA-5530

stIncMale

The last reviewed commit is c2d9b07.

driver-core/src/main/com/mongodb/internal/async/AsyncBatchCursor.java

driver-core/src/main/com/mongodb/internal/operation/BatchCursor.java

...ore/src/test/functional/com/mongodb/internal/operation/CommandBatchCursorFunctionalTest.java

...rc/test/functional/com/mongodb/internal/operation/AsyncCommandBatchCursorFunctionalTest.java

…WriteOperation.java Co-authored-by: Valentin Kovalenko <[email protected]>

…or.java Co-authored-by: Valentin Kovalenko <[email protected]>

…WriteOperation.java Co-authored-by: Valentin Kovalenko <[email protected]>

- Remove redundunt checks. - Rename test methods. JAVA-5530

JAVA-5530

driver-core/src/main/com/mongodb/internal/operation/ClientBulkWriteOperation.java

driver-sync/src/test/functional/com/mongodb/client/CrudProseTest.java

driver-core/src/main/com/mongodb/internal/operation/ClientBulkWriteOperation.java

Co-authored-by: Valentin Kovalenko <[email protected]>

stIncMale

Thank you 👍 Though something is suspicious with the test failures - there seem to be too many of them.

vbabanin · 2024-12-20T22:56:57Z

Thank you for the great suggestions, @stIncMale! The structure of the async code now aligns more closely with the sync code.

Regarding the tests, the Azure tests failed due to network connectivity issues. After rerunning, they are consistently green.

Add improved Bulk Write API for Java Reactive Driver

e352b31

- Created and documented the new Reactive Bulk Write API - Enabled unified and prose tests for reactive Bulk Write API JAVA-5530

vbabanin self-assigned this Dec 13, 2024

vbabanin added 3 commits December 13, 2024 19:25

Disable Kotlin tests.

a05882d

JAVA-5530

Remove redundant methods.

78760c0

JAVA-5530

Remove TODOs.

cb0d596

JAVA-5530

vbabanin commented Dec 14, 2024

View reviewed changes

vbabanin added 2 commits December 13, 2024 22:15

Fix retryable wrapping.

9e9f33d

JAVA-5530

Remove comments.

9ca1fe7

JAVA-5530

vbabanin marked this pull request as ready for review December 14, 2024 06:25

vbabanin requested a review from stIncMale December 14, 2024 06:25

Remove test skips.

9a7d9ba

JAVA-5530

stIncMale requested changes Dec 16, 2024

View reviewed changes

vbabanin and others added 9 commits December 16, 2024 14:26

Update driver-sync/src/test/functional/com/mongodb/client/CrudProseTe…

0ca8859

…st.java Co-authored-by: Valentin Kovalenko <[email protected]>

Update driver-sync/src/test/functional/com/mongodb/client/CrudProseTe…

99a460a

…st.java Co-authored-by: Valentin Kovalenko <[email protected]>

Update driver-core/src/main/com/mongodb/internal/async/MutableValue.java

ae8763f

Co-authored-by: Valentin Kovalenko <[email protected]>

Update driver-reactive-streams/src/main/com/mongodb/reactivestreams/c…

7001d9e

…lient/MongoCluster.java Co-authored-by: Valentin Kovalenko <[email protected]>

Update driver-core/src/main/com/mongodb/internal/async/AsyncRunnable.…

bee199e

…java Co-authored-by: Valentin Kovalenko <[email protected]>

Apply suggestions from code review

e6a0a7e

Co-authored-by: Valentin Kovalenko <[email protected]>

Update javadoc.

df2cb88

Remove redundant methods. JAVA-5530

Make CursorHelper generic.

f43fc49

JAVA-5530

Move exhaustCursor method to cursor interface.

b7c5bfa

JAVA-5530

stIncMale requested changes Dec 17, 2024

View reviewed changes

Add assertions.

c2d9b07

JAVA-5530

stIncMale requested changes Dec 17, 2024

View reviewed changes

vbabanin and others added 6 commits December 16, 2024 22:58

Update driver-core/src/main/com/mongodb/internal/operation/ClientBulk…

9c23736

…WriteOperation.java Co-authored-by: Valentin Kovalenko <[email protected]>

Update driver-core/src/main/com/mongodb/internal/operation/ClientBulk…

f091561

…WriteOperation.java Co-authored-by: Valentin Kovalenko <[email protected]>

Update driver-core/src/main/com/mongodb/internal/async/AsyncBatchCurs…

91030ab

…or.java Co-authored-by: Valentin Kovalenko <[email protected]>

Update driver-core/src/main/com/mongodb/internal/operation/ClientBulk…

24ce23d

…WriteOperation.java Co-authored-by: Valentin Kovalenko <[email protected]>

Update driver-core/src/main/com/mongodb/internal/operation/ClientBulk…

b775ea4

…WriteOperation.java Co-authored-by: Valentin Kovalenko <[email protected]>

Update driver-core/src/main/com/mongodb/internal/operation/ClientBulk…

8110a09

…WriteOperation.java Co-authored-by: Valentin Kovalenko <[email protected]>

vbabanin and others added 2 commits December 16, 2024 23:09

Update driver-core/src/main/com/mongodb/internal/operation/ClientBulk…

e8c1520

…WriteOperation.java Co-authored-by: Valentin Kovalenko <[email protected]>

- Adress formatting issues.

8f3e522

- Remove redundunt checks. - Rename test methods. JAVA-5530

vbabanin requested a review from stIncMale December 17, 2024 08:10

vbabanin added 5 commits December 17, 2024 00:14

Fix static checks.

dc85f96

JAVA-5530

Fix test.

c0b7292

JAVA-5530

Remove throws.

fc02c9a

JAVA-5530

Remove redundant method.

3f36b21

JAVA-5530

Fix typo.

190a067

JAVA-5530

stIncMale reviewed Dec 20, 2024

View reviewed changes

Apply suggestions from code review

3019e07

Co-authored-by: Valentin Kovalenko <[email protected]>

vbabanin requested a review from stIncMale December 20, 2024 18:02

stIncMale approved these changes Dec 20, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add improved Bulk Write API for Java Reactive Driver #1583

Add improved Bulk Write API for Java Reactive Driver #1583

vbabanin commented Dec 13, 2024

vbabanin Dec 14, 2024

stIncMale left a comment

stIncMale Dec 17, 2024

stIncMale left a comment

stIncMale left a comment

vbabanin commented Dec 20, 2024 •

edited

Loading

Add improved Bulk Write API for Java Reactive Driver #1583

Are you sure you want to change the base?

Add improved Bulk Write API for Java Reactive Driver #1583

Conversation

vbabanin commented Dec 13, 2024

vbabanin Dec 14, 2024

Choose a reason for hiding this comment

stIncMale left a comment

Choose a reason for hiding this comment

stIncMale Dec 17, 2024

Choose a reason for hiding this comment

stIncMale left a comment

Choose a reason for hiding this comment

stIncMale left a comment

Choose a reason for hiding this comment

vbabanin commented Dec 20, 2024 • edited Loading

vbabanin commented Dec 20, 2024 •

edited

Loading