-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL-1310: Add release targets for ODBC on macos #131
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this produce files to test? I'm not seeing them in evergreen
@terakilobyte I was actually expecting evergreen to fail since I don't have the credentials for the macnotary yet. |
Are we really comfortable releasing the mac driver without testing it with any tool? A sanity check with a tool supporting generic ODBC connections would be good, no? |
I'm waiting on the credentials for this. Want to see it working. @nbagnard we need to test with tableau imo |
Yes, that's a good idea to test with a tool supporting generic ODBC. I'm planning on testing this with Tableau when I get a new license key. |
I tried Tableau with the Intel driver and was able to connect. I used the DSN method and it showed the Looking at the trace, I see it has a problem with the
Checked with Natacha and we don't think this Mac driver is ready for release just yet. |
I think it's probably fine that it's failing on that step since users will ideally use jdbc for tableau. We see that it's working other than that. We can just document that we do not yet support SQLBindCol, and probably file a ticket to support it (maybe an epic?) |
Though, I do think it's best just to schedule the Mac support out as we discussed before. Ignore me here. |
Added signing using the
mac.sign
evergreen task.Requested credentials from the BUILD team for $key_id and $secret values. I will add them to our project and fully test the signing for this patch prior to merging.
Added the installer path to
mongo-odbc-downloads_template.json
.