-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPC-1489: Deprecate integer readPreference constants #1604
PHPC-1489: Deprecate integer readPreference constants #1604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you keep any test that use the legacy constants to ensure they still work even if they are deprecated?
@@ -12,30 +12,35 @@ final class ReadPreference implements \MongoDB\BSON\Serializable, \Serializable | |||
/** | |||
* @var int | |||
* @cvalue MONGOC_READ_PRIMARY | |||
* @deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be sync with 3rd party stubs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll take care of those alongside the documentation
Added now. |
Note: I'll have to revisit the failing Windows Build tasks for PHP 7.4 and 8.0 separately - deferring the merge until those have been taken care of. |
* master: (22 commits) PHPC-2434: Add PHP 8.4 to GitHub Actions (#1625) PHPC-2421, PHPC-2428: Update bundled dependencies (#1622) Don't build libmongoc version in pull requests Use drivers-evergreen-tools for Windows testing (#1615) PHPC-1957 Add tests for out-of-range UTCDateTime values (#1614) PHPC-2286 Implement `UTCDateTime::toDateTimeImmutable` (#1611) PHPC-2414, PHPC-2415: Update wire versions for MongoDB 8.0 compatibility (#1610) PHPC-2349, PHPC-2411: Deprecate unused exception classes (#1608) Fix failing tests on x86 systems (#1609) PHPC-2347: Deprecate BSON functions (#1607) PHPC-1489: Deprecate integer readPreference constants (#1604) Fix version computation for libmongoc development versions (#1599) PHPC-2376: Test against MongoDB 8.0 (#1598) PHPC-2254: Relax server selection timeout error message pattern (#1587) PHPC-2401: Support QEv2 range protocol (#1583) PHPC-2398: Use server_id methods for libmongoc 1.28+ (#1582) PHPC-2395: Fetch Atlas connectivity URIs from AWS Secrets Manager (#1579) Merge v1.19 into master (#1578) Revert "Bump mongodb-labs/drivers-github-tools from 1 to 2 (#1568)" (#1571) Bump mongodb-labs/drivers-github-tools from 1 to 2 (#1568) ...
PHPC-1489
This deprecates the
RP_*
constants inMongoDB\Driver\ReadPreference
constants, along with passing an int in the constructor and usinggetMode
.Note that PHP 8.3 and newer automagically triggers warnings when using deprecated warnings. Calling deprecated methods results in a warning starting in PHP 7.4 (albeit with a wrong message in PHP 7.4).