Use forked setup-php-sdk action to fix download issues #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
changed the title
GromNaN
approved these changes
Jul 5, 2024
| @@ -31,7 +31,7 @@ runs: | |||
|
|
|||
| - name: Setup PHP SDK | |||
| id: setup-php | |||
| uses: php/setup-php-sdk@v0.8 | |||
| uses: alcaeus/setup-php-sdk@fix-old-php-install | |||
There was a problem hiding this comment.
Checked the diff: php/setup-php-sdk@main...alcaeus:setup-php-sdk:fix-old-php-install
Is it something you will contribute back to the project?
There was a problem hiding this comment.
I always do: php/setup-php-sdk#2
|
Closing as we've found a different solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages for old PHP versions are have moved to a different folder, causing download issues in the setup-php-sdk action. This PR switches to a forked version until the upstream action is fixed.