PHPC-2140: Make tentative return types definitive #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
phpc-2140-return-types
branch
from
835aafa
to
4a3cec7
Compare
GromNaN
reviewed
Sep 18, 2024
alcaeus
force-pushed
the
phpc-2140-return-types
branch
3 times, most recently
from
4aebdee
to
fc1f63f
Compare
jmikola
approved these changes
Sep 18, 2024
| @@ -9,18 +9,17 @@ | |||
|
|
|||
| interface CursorInterface extends \Iterator | |||
| { | |||
| /** @tentative-return-type */ | |||
| public function current(): array|object|null {} | |||
There was a problem hiding this comment.
Do I assume correctly that only current() and key() are included here because those are the only methods where we'd narrowing the return type from the parent interface?
There was a problem hiding this comment.
This methods are mentioned in the upgrade file:
The return types for the
keyandcurrentmethods have been narrowed to the types returned by cursor instances.
GromNaN
approved these changes
Sep 18, 2024
alcaeus
force-pushed
the
phpc-2140-return-types
branch
from
fc1f63f
to
ddf31af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPC-2140
This PR removes the
@tentative-return-typeannotation in all stub files, making the return types definitive and causing errors if an extending or implementing class does not have a covariant return type.It also changes the return types for various methods in
MongoDB\Driver\ManagerandMongoDB\Driver\ServerfromCursortoCursorInterface.Note: currently contains changes from #1653 to avoid fixing tests that will be removed.