PHPC-2144 Throw a LogicException when getting info from unacknowledged write result #1687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPC-2144
Transform deprecation to exception. The exception message comes from PHPLIB: https://github.com/mongodb/mongo-php-library/blob/v1.x/src/Exception/BadMethodCallException.php#L45
And remove nullable return types from
WriteResult::get*Count
accessors