Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPC-2468: Update to libmongoc 1.28.1 #1725

Merged
merged 1 commit into from
Oct 17, 2024
Merged

PHPC-2468: Update to libmongoc 1.28.1 #1725

merged 1 commit into from
Oct 17, 2024

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Oct 16, 2024

@alcaeus alcaeus requested a review from jmikola October 16, 2024 08:27
@alcaeus alcaeus mentioned this pull request Oct 16, 2024
Merged
jmikola
jmikola approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM but I assume you still want to look into the missing toolset errors for the failing Windows builds.

This was referenced Oct 16, 2024
Closed
Closed
@alcaeus alcaeus enabled auto-merge (squash) October 17, 2024 09:06
@alcaeus alcaeus merged commit ef4a6e8 into mongodb:v1.20 Oct 17, 2024
79 of 80 checks passed
@mongodb-php-bot mongodb-php-bot mentioned this pull request Oct 17, 2024
Merged
@alcaeus alcaeus deleted the phpc-2468-update-libmongoc branch October 17, 2024 09:22
@mongodb-php-bot mongodb-php-bot mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikola jmikola jmikola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alcaeus @jmikola