fix(NODE-6377): remove noResponse option #4240
Open
+72
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lint fix lont fix 2
temp temp2
aditi-khare-mongoDB
force-pushed
the
NODE-6377/remove-noResponse
branch
from
0342d92
to
419a848
Compare
aditi-khare-mongoDB
changed the title
aditi-khare-mongoDB
changed the base branch from
main
to
NODE-6060/fire-and-forget
nbbeeken
added
the
Primary Review
nbbeeken
requested changes
Sep 23, 2024
nbbeeken
added
Team Review
durran
requested changes
Sep 24, 2024
durran
previously approved these changes
Sep 24, 2024
nbbeeken
requested changes
Sep 25, 2024
nbbeeken
requested changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that unacknowledged writes are supported through
writeConcern.w = 0, remove the buggynoResponse optioninternally and in public APIs.What is changing?
CommandOperationOptionsAPIclient.close()andRunAdminCommandOperationto usewriteConcerninsteadIs there new documentation needed for these changes?
None, except removing the option from the Public API.
What is the motivation for this change?
NODE-6060.
Release Highlight
Remove
CommandOperationOptions.noResponseoptionSetting the
noResponseoption onCommandOperationOptionswould result in indeterminate socket behavior leading to either silent or thrown errors on any following operations. Since this option is broken and causes bugs, we're removing it to call attention to any code that may have been using it inadvertently.In order to correctly request that the driver recieves 'no response' from the server (usually to perform an unacknowledged write) setting the
WriteConcern.wproperty to0is the recommended migration.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript