Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-6391): Add timeoutMS support to explicit encryption #4269

Draft
wants to merge 28 commits into
base: NODE-6090
Choose a base branch
from

Conversation

aditi-khare-mongoDB
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB commented Oct 8, 2024

Description

What is changing?

Add timeoutMS support to

  • ClientEncryptionOptions
  • the following ClientEncryption helper functions:
    • encrypt
    • decrypt
    • createDataKey
    • createEncryptedCollection

Implemented spec prose tests for the above (createDataKey, encrypt, decrypt)
Add integration test for createEncryptedCollection and CSOT
Add unit tests for ClientEncryption getting a timeoutMS value from client and/or ClientEncryptionOptions

Is there new documentation needed for these changes?

During release

What is the motivation for this change?

Spec Compliance

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

W-A-James and others added 18 commits October 1, 2024 14:06
Co-authored-by: Neal Beeken <[email protected]>
Co-authored-by: Bailey Pearson <[email protected]>
…4243)

Co-authored-by: Warren James <[email protected]>
Co-authored-by: Neal Beeken <[email protected]>
Co-authored-by: Bailey Pearson <[email protected]>
Copy link

There is an existing patch(es) for this commit SHA:

Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'.

@aditi-khare-mongoDB aditi-khare-mongoDB changed the title Node 6391/explicit encryption feat(NODE-6391): Add timeoutMS support to explicit encryption Oct 8, 2024
temp

temp

Delete test/integration/client-side-encryption/client_side_encryption.test.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants