DRIVERS-2884 Avoid connection churn when operations timeout #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
reviewed
Oct 15, 2024
| data: | ||
| failCommands: ["insert"] | ||
| blockConnection: true | ||
| blockTimeMS: 750 |
There was a problem hiding this comment.
I worry that these tests rely on the undocumented behavior of failCommand+blockTimeMS with maxTimeMS. What if the server decides to enforce maxTimeMS even inside failCommand?
| eventType: cmap | ||
| events: | ||
| - connectionClosedEvent: | ||
| reason: error |
There was a problem hiding this comment.
Should this case result in the connection being closed? I propose the connection remain pending for as many operations as it takes to read the response up to some reasonably small limit like 1-5 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please complete the following before merging:
clusters, and serverless).