fix: uses SchemaConfigModeAttr for list attributes in cluster resourc…

…e. (#1654) * fix: uses SchemaConfigModeAttr for list attributes. * test. * test.
mongodb · Nov 22, 2023 · d76dfd6 · d76dfd6
1 parent 7074c0b
commit d76dfd6
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 12 deletions.
diff --git a/mongodbatlas/resource_mongodbatlas_cloud_backup_snapshot.go b/mongodbatlas/resource_mongodbatlas_cloud_backup_snapshot.go
@@ -444,8 +444,9 @@ func flattenCloudProviderSnapshotBackupPolicy(ctx context.Context, d *schema.Res
 
 func computedCloudProviderSnapshotBackupPolicySchema() *schema.Schema {
 	return &schema.Schema{
-		Type:     schema.TypeList,
-		Computed: true,
+		Type:       schema.TypeList,
+		Computed:   true,
+		ConfigMode: schema.SchemaConfigModeAttr,
 		Elem: &schema.Resource{
 			Schema: map[string]*schema.Schema{
 				"cluster_id": {
@@ -477,17 +478,19 @@ func computedCloudProviderSnapshotBackupPolicySchema() *schema.Schema {
 					Computed: true,
 				},
 				"policies": {
-					Type:     schema.TypeList,
-					Computed: true,
+					Type:       schema.TypeList,
+					Computed:   true,
+					ConfigMode: schema.SchemaConfigModeAttr,
 					Elem: &schema.Resource{
 						Schema: map[string]*schema.Schema{
 							"id": {
 								Type:     schema.TypeString,
 								Computed: true,
 							},
 							"policy_item": {
-								Type:     schema.TypeList,
-								Computed: true,
+								Type:       schema.TypeList,
+								Computed:   true,
+								ConfigMode: schema.SchemaConfigModeAttr,
 								Elem: &schema.Resource{
 									Schema: map[string]*schema.Schema{
 										"id": {

diff --git a/mongodbatlas/resource_mongodbatlas_cluster.go b/mongodbatlas/resource_mongodbatlas_cluster.go
@@ -1529,8 +1529,9 @@ func getContainerID(containers []matlas.Container, cluster *matlas.Cluster) stri
 
 func clusterConnectionStringsSchema() *schema.Schema {
 	return &schema.Schema{
-		Type:     schema.TypeList,
-		Computed: true,
+		Type:       schema.TypeList,
+		Computed:   true,
+		ConfigMode: schema.SchemaConfigModeAttr,
 		Elem: &schema.Resource{
 			Schema: map[string]*schema.Schema{
 				"standard": {
@@ -1550,17 +1551,19 @@ func clusterConnectionStringsSchema() *schema.Schema {
 					Computed: true,
 				},
 				"private_endpoint": {
-					Type:     schema.TypeList,
-					Computed: true,
+					Type:       schema.TypeList,
+					Computed:   true,
+					ConfigMode: schema.SchemaConfigModeAttr,
 					Elem: &schema.Resource{
 						Schema: map[string]*schema.Schema{
 							"connection_string": {
 								Type:     schema.TypeString,
 								Computed: true,
 							},
 							"endpoints": {
-								Type:     schema.TypeList,
-								Computed: true,
+								Type:       schema.TypeList,
+								Computed:   true,
+								ConfigMode: schema.SchemaConfigModeAttr,
 								Elem: &schema.Resource{
 									Schema: map[string]*schema.Schema{
 										"endpoint_id": {

diff --git a/mongodbatlas/resource_mongodbatlas_cluster_test.go b/mongodbatlas/resource_mongodbatlas_cluster_test.go
@@ -48,6 +48,10 @@ func TestAccClusterRSCluster_basicAWS_simple(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "version_release_system", "LTS"),
 					resource.TestCheckResourceAttr(resourceName, "accept_data_risks_and_force_replica_set_reconfig", ""),
 					resource.TestCheckResourceAttr(resourceName, "auto_scaling_disk_gb_enabled", "true"),
+					resource.TestCheckResourceAttrSet(resourceName, "snapshot_backup_policy.#"),
+					resource.TestCheckResourceAttrSet(resourceName, "snapshot_backup_policy.0.policies.#"),
+					resource.TestCheckResourceAttrSet(resourceName, "connection_strings.#"),
+					resource.TestCheckResourceAttrSet(resourceName, "connection_strings.0.private_endpoint.#"),
 				),
 			},
 			{