-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Mongoid::Search::Util.normalize_keywords #138
Conversation
Use unicode_normalize instead of normalize as this is deprecated as of Rails 6.0 and will be removed in Rails 6.1
Generated by 🚫 danger |
Is it possible for someone to take a look at this? It seems like other people seem to be having his issue as well. #139 |
This should really be accepted since @yads made a fix that will benefit everyone. |
I merged it, but I am not a maintainer of this project. Anyone actively using this repo add your name to #111, let's find some more maintainers? |
I added my name to #111. Can you add me as a contributor? I can try to do a release. Thanks. |
This project is owned by @mauriciozaffari (and others) so will have to leave it for them. I help out with the parent |
@dblock and @mauriciozaffari - trying to revisit this topic. Any updates on a release? |
@aparmar I've pushed out a new release 0.4.0 that now has this change. |
@yads. Thanks for making the release. I can see it on rubygems. Should we tag 0.4.0 here as well? |
Tagged in github, thanks @aparmar. |
Use unicode_normalize instead of normalize as this is deprecated as of Rails 6.0 and will be removed in Rails 6.1
This may not be compatible with earlier versions of mongoid as this method was added in Ruby 2.2