Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mongoid::Search::Util.normalize_keywords #138

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Conversation

yads
Copy link
Collaborator

@yads yads commented Nov 25, 2019

Use unicode_normalize instead of normalize as this is deprecated as of Rails 6.0 and will be removed in Rails 6.1

This may not be compatible with earlier versions of mongoid as this method was added in Ruby 2.2

Use unicode_normalize instead of normalize as this is deprecated as of Rails 6.0 and will be removed in Rails 6.1
@rtrv-bot
Copy link

rtrv-bot commented Nov 25, 2019

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

@yads
Copy link
Collaborator Author

yads commented Dec 6, 2019

Is it possible for someone to take a look at this? It seems like other people seem to be having his issue as well. #139

@aparmar
Copy link

aparmar commented Mar 19, 2020

This should really be accepted since @yads made a fix that will benefit everyone.

@dblock dblock merged commit 3b43a45 into mongoid:master Mar 19, 2020
@dblock
Copy link
Contributor

dblock commented Mar 19, 2020

I merged it, but I am not a maintainer of this project.

Anyone actively using this repo add your name to #111, let's find some more maintainers?

@aparmar
Copy link

aparmar commented Mar 23, 2020

I added my name to #111. Can you add me as a contributor? I can try to do a release. Thanks.

@dblock
Copy link
Contributor

dblock commented Mar 23, 2020

I added my name to #111. Can you add me as a contributor? I can try to do a release. Thanks.

This project is owned by @mauriciozaffari (and others) so will have to leave it for them. I help out with the parent mongoid org.

@aparmar
Copy link

aparmar commented Jul 5, 2020

@dblock and @mauriciozaffari - trying to revisit this topic. Any updates on a release?

@yads
Copy link
Collaborator Author

yads commented Jul 7, 2020

@aparmar I've pushed out a new release 0.4.0 that now has this change.

@aparmar
Copy link

aparmar commented Jul 8, 2020

@yads. Thanks for making the release. I can see it on rubygems. Should we tag 0.4.0 here as well?

@yads
Copy link
Collaborator Author

yads commented Jul 8, 2020

Tagged in github, thanks @aparmar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants