Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS React Native implementation #495

Open
wants to merge 36 commits into
base: v3
Choose a base branch
from

Conversation

KseniaBuntova
Copy link

Technical description

  • Feature description...

Tested on

Steps to reproduce

Screenshots (optional):

No screenshots.

This Pull Request template has been written and generated by Monk JS repository.

KseniaBuntova and others added 11 commits March 21, 2023 19:18
* fix: resolve sentry warnings (MN-226)

* Added dummy text for MN-139 (live doc) QA

* Remove the dummy doc line for the QA

* update the translation copy for permission msg if user doesn't have the permission to create a new inspection

* render the UI to show the permission error in view

* implemented the conditional logic to render UI with different error messages on creating a new inspection

* a minor fix

* update Sentry doc with the required delay before redirecting to another URL

* fix auto formatting issue

* remove comment from code

* Updated the overlay of wheels sights

* Fixed ffocus18-x_1SE7X- sight name

* Reverted the changes made to the wheels sights

* Added new zoomed in sights for the wheels

* Added custom zoomed sights for jgc wheels

* Make the documentation clear and easy on how to implement the Sentry monitoring (monkvision#465)

* Added damage detection to wheels sights in demo app (monkvision#466)

Co-authored-by: souyahia-monk <[email protected]>

* Fixed glitched overlay for ff150-3lKZIoxw (monkvision#469)

Co-authored-by: souyahia-monk <[email protected]>

* add damage-severity and sub image parts in request payload when creating a new inspection (monkvision#471)

* feat: implememnt sentry add damage metrics (MN-239) (monkvision#467)

Co-authored-by: deepakglobant <[email protected]>

* Added back car coverage (monkvision#477)

Co-authored-by: souyahia-monk <[email protected]>

* Release @monkvision/monkjs v3.7.0

* Added even more zoomed wheel sights (monkvision#481)

Co-authored-by: souyahia-monk <[email protected]>

* enable car coverage for compliance (monkvision#485)

* add translation copy for no-car compliance error message (monkvision#486)

* Release @monkvision/monkjs v3.7.1

* add translation copy for compliance errors (monkvision#488)

* Release @monkvision/monkjs v3.7.2

* change logic to match the compliance error code with mapped translation copy (monkvision#490)

* Release @monkvision/monkjs v3.7.3

* feat: allow user to add custom tags (MN-274) (monkvision#493)

Co-authored-by: deepakglobant <[email protected]>

* Release @monkvision/monkjs v3.7.4

* Remove &quot; from ff150-3lKZIoxw.svg (monkvision#487)

* fix merge

* fix crashes

---------

Co-authored-by: deepakglobant <[email protected]>
Co-authored-by: souyahia-monk <[email protected]>
Co-authored-by: Samy Ouyahia <[email protected]>
Co-authored-by: deepakglobant <[email protected]>
Co-authored-by: Rohit Sharma <[email protected]>
Co-authored-by: rohitsharma120582 <[email protected]>
Co-authored-by: Thomas Peters <[email protected]>
# Conflicts:
#	packages/sights/assets/overlays/fesc20-4Wqx52oU.svg
#	packages/sights/assets/overlays/fesc20-5Ts1UkPT.svg
#	packages/sights/assets/overlays/fesc20-Tlu3sz8A.svg
#	packages/sights/assets/overlays/fesc20-W6XrryMO.svg
#	packages/sights/assets/overlays/fesc20-WIQsf_gX.svg
#	packages/sights/assets/overlays/fesc20-YPcJPAZE.svg
#	packages/sights/assets/overlays/fesc20-dKVLig1i.svg
#	packages/sights/assets/overlays/fesc20-raHPDUNm.svg
#	packages/sights/assets/overlays/ff150-3rM9XB0Z.svg
#	packages/sights/assets/overlays/ff150-7nvlys8r.svg
#	packages/sights/assets/overlays/ff150-7vyfzrVQ.svg
#	packages/sights/assets/overlays/ff150-FqbrFVr2.svg
#	packages/sights/assets/overlays/ff150-H3MCPESJ.svg
#	packages/sights/assets/overlays/ff150-jUBEKij0.svg
#	packages/sights/assets/overlays/ff150-ouGGtRnf.svg
#	packages/sights/assets/overlays/ff150-pNO26q4D.svg
#	packages/sights/assets/overlays/ffocus18-Eo0jqD_a.svg
#	packages/sights/assets/overlays/ffocus18-JFX8WF9P.svg
#	packages/sights/assets/overlays/ffocus18-S3kgFOBb.svg
#	packages/sights/assets/overlays/ffocus18-jkSlWpql.svg
#	packages/sights/assets/overlays/ffocus18-tufa4FoL.svg
#	packages/sights/assets/overlays/ffocus18-x_1SE7X-.svg
#	packages/sights/assets/overlays/ftransit18-3Sbfx_KZ.svg
#	packages/sights/assets/overlays/ftransit18-4NMPqEV6.svg
#	packages/sights/assets/overlays/ftransit18-7qLSCnFP.svg
#	packages/sights/assets/overlays/ftransit18-AuCXxG5o.svg
#	packages/sights/assets/overlays/ftransit18-RJ2D7DNz.svg
#	packages/sights/assets/overlays/ftransit18-Y0vPhBVF.svg
#	packages/sights/assets/overlays/ftransit18-mGSvkRHz.svg
#	packages/sights/assets/overlays/ftransit18-yxw9gmyL.svg
#	packages/sights/assets/overlays/haccord-2v-2_QD5.svg
#	packages/sights/assets/overlays/haccord-9fxMGSs6.svg
#	packages/sights/assets/overlays/haccord-GQcZz48C.svg
#	packages/sights/assets/overlays/haccord-H_eRrLBl.svg
#	packages/sights/assets/overlays/haccord-KN23XXkX.svg
#	packages/sights/assets/overlays/haccord-OXYy5gET.svg
#	packages/sights/assets/overlays/haccord-W-Bn3bU1.svg
#	packages/sights/assets/overlays/haccord-boMeNVsC.svg
#	packages/sights/assets/overlays/jgc21-2bGeRS3I.svg
#	packages/sights/assets/overlays/jgc21-3gjMwvQG.svg
#	packages/sights/assets/overlays/jgc21-RAVpqaE4.svg
#	packages/sights/assets/overlays/jgc21-S8sE69on.svg
#	packages/sights/assets/overlays/jgc21-nVbhsBaQ.svg
#	packages/sights/assets/overlays/jgc21-s7WDTRmE.svg
#	packages/sights/assets/overlays/jgc21-xwYV3_Hz.svg
#	packages/sights/assets/overlays/jgc21-z15ZdJL6.svg
#	packages/sights/assets/overlays/tsienna20-2Zz6SEaI.svg
#	packages/sights/assets/overlays/tsienna20-65mfPdRD.svg
#	packages/sights/assets/overlays/tsienna20-670P2H2V.svg
#	packages/sights/assets/overlays/tsienna20-K0ThKmue.svg
#	packages/sights/assets/overlays/tsienna20-RP6TzN4w.svg
#	packages/sights/assets/overlays/tsienna20-SebsoqJm.svg
#	packages/sights/assets/overlays/tsienna20-cI285Gon.svg
#	packages/sights/assets/overlays/tsienna20-uz29ILgw.svg
@rohitsharma120582 rohitsharma120582 self-requested a review May 23, 2023 08:00
Copy link
Contributor

@rohitsharma120582 rohitsharma120582 Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ESLint configuration issues
  • App is not making an API call to upload the captured image for each sight in Capture Tour. This is also blocking the capture tour getting completed in web app

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my-end testing:

  1. Web-app is working fine and making all necessary API calls as well. I don't find any issues in any API calls now.
  2. Whereas, I am still getting ESLint errors when running the following command:
cd packages/camera
yarn lint

Also plz refer the below code for a few error messages

/Users/rohit.sharma/workspace/projects/ACV/client_apps/maxsystems/packages/camera/src/components/AddDamageModal/PartSelector.js
   6:32  error  Missing file extension for "./SVGComponentMapper"  import/extensions
  36:9   error  'Platform' is not defined                          no-undef

/Users/rohit.sharma/workspace/projects/ACV/client_apps/maxsystems/packages/camera/src/components/AddDamageModal/SVGComponentMapper.native.js
  16:25  error  'element' is already declared in the upper scope on line 15 column 46  no-shadow
  17:52  error  Unary operator '++' used                                               no-plusplus
  26:50  error  Unary operator '++' used                                               no-plusplus
  52:3   error  'elementChildren' is never reassigned. Use 'const' instead             prefer-const
  54:52  error  Unary operator '++' used                                               no-plusplus

/Users/rohit.sharma/workspace/projects/ACV/client_apps/maxsystems/packages/camera/src/components/Camera/index.native.js
  29:14  error  Redundant use of `await` on a return value  no-return-await

Plz fix the lint issues, only then it will allow to create and pass the build, if we merge this PR.

Copy link
Contributor

@rohitsharma120582 rohitsharma120582 Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your PR and found following two things to fix/change:

  • I still see ESLint issue in 2-3 files. I tried to fix them & push changes in your repo, but couldn't do it due to permission. So please either give me a permission or fix the issues at your end. ( We can connect and I can help you to fix those issues over the call itself)
  • Please let me know about the SVG files changes in your PR. Is it done purposely and what significant change is it? If we want to merge your PR, then we would recommend you to remove these changes in your PR to avoid any consequences in web/mobile app during rendering the required SVG files.

KseniaBuntova and others added 10 commits September 6, 2023 11:52
# Conflicts:
#	packages/camera/src/components/AddDamageOverlay/index.js
#	packages/camera/src/components/Capture/capture.js
#	packages/camera/src/components/Capture/hooks.js
#	packages/corejs/package.json
#	packages/cra-template/package.json
#	packages/inspection-report/package.json
#	packages/inspection-report/src/components/DamageReport/Accordion.js
#	packages/inspection-report/src/components/DamageReport/DamageManipulator.js
#	packages/inspection-report/src/components/DamageReport/DamageReport.js
#	packages/inspection-report/src/components/DamageReport/UpdateDamageModal.js
#	packages/inspection-report/src/components/DamageReport/UpdateDamagePopUp/index.js
#	packages/inspection-report/src/components/DamageReport/hooks/useDamageReportStateHandlers.js
#	packages/inspection-report/src/components/DamageReport/hooks/useFetchInspection.js
#	packages/inspection-report/src/components/DamageReport/hooks/useProcessInspection.js
#	packages/inspection-report/src/components/Gallery/Thumbnail.js
#	packages/inspection-report/src/components/Gallery/index.js
#	packages/inspection-report/src/i18n/resources/en.js
#	packages/inspection-report/src/i18n/resources/fr.js
# Conflicts:
#	packages/inspection-report/src/components/DamageReport/DamageReport.js
#	packages/inspection-report/src/components/DamageReport/UpdateDamageModal.js
#	packages/inspection-report/src/components/DamageReport/hooks/useDamageReportStateHandlers.js
#	packages/inspection-report/src/components/Gallery/index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants