Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support VS Mac 17.x #131

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Support VS Mac 17.x #131

wants to merge 3 commits into from

Conversation

mrward
Copy link
Member

@mrward mrward commented Jun 6, 2022

Not sure if this the best approach. I tried to minimise the changes needed to get t4 templating working in VS Mac 17.x

  • VS Mac bundles its own dotnet runtime which was causing problems for the RuntimeInfo class since there is no sdk available.
    • Allow the sdk to be missing when using the Roslyn code compiler.
  • Ensure best C# language version is used when the Roslyn code compiler is used.

Running the text templating engine within Visual Studio for Mac fails
since the RuntimeInfo fails to find any SDK directory.

When using the Roslyn code compiler there is now no exception if no
SDK is found. The SDK location is not needed for the Roslyn compiler
since there is no external csc.dll to run.

Also use a better default C# lang version for the Roslyn code compiler
instead of 7.0
The CSharpParseOptions was not using the best language version. The
CSharpParseOptions was created but no language version was used from
the RuntimeInfo nor the language version specified by the Roslyn code
compiler.
Not needed on the RuntimeInfo class anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant