-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure to normal python package #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks fantastic!
I wonder if it's easy / possible / worthwhile to add druid-upload
and druid-download
to the PATH as well? That said, I wonder if they are necessary at all. Does the ease of not needing to type u <filename>
or p
inside of druid
surpass the potential confusion of having the separate python programs? I'm leaning toward just-one-tool-that-does-those-things.
CC @csboling before I merge these changes, wanted to check if you have opinions about this direction?
I'm super excited to just be able to type druid
in terminal!!
Oh man, awesome. Clearly your pipcraft is stronger than mine. I've tried to get this kind of thing working for scripts many times in the past and have always had some variation I wasn't really happy with. I'm also super in favor of the namespace reorg to make local imports work as expected. |
Noticed we need to update the scripting tutorial if we merge these changes. Since the docs live in a different repo I'll create a PR there as well. Will do so tomorrow. |
I think we should also tag this release so we can tell people to download a certain version. another command-line arg would be good to query: eg: |
Yeah, good point. Shall we tag a first release when we've rolled the upload and download actions into druid (assuming everyone agrees with that approach)? |
sounds great to me. do you want me to have a go at the upload/download, or do you want to jump in (i won't be able to get to it til tomorrow earliest) |
I'll do it tomorrow, better to keep you free for other stuff :) |
8eaf6b5
to
cc27ce0
Compare
@@ -0,0 +1,35 @@ | |||
#!/usr/bin/env python3 | |||
|
|||
from setuptools import setup, find_namespace_packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simonvanderveldt I am getting an ImportError for find_namespace_packages on this line on Python 3.6.5 on an OSX VM. Not sure if this is maybe new in Python 3.7? Or maybe updating pip would fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohw, yeah, that's annoying, you need a newer setuptools. They should just include it in the Python package but alas.
So that either means adding more instructions or assuming people have setuptools installed and switching to using find_packages
and including __init__.py
files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the readme to include updating setuptools and I've removed the virtualenv section, users should just use pip install --user
, people that want to develop/work on it I assume know what they're doing and even if we want to document it for them it should be in a separate readme.
cc27ce0
to
18f8373
Compare
18f8373
to
64a842b
Compare
I've added a PR to update the docs as well monome/docs#142, I think this is all ready. |
6eff777
to
f999951
Compare
f999951
to
a809cfc
Compare
Merged! I'll add the changes to scripting.md now to cover |
As prepwork for publishing to pypi and to make it clearer/simpler to install and use.
Also fixed a bunch of PEP8/linting issues.
I only fixed the simple/non-invasive ones though, will have a look at the rest later.
How to use after these changes (see readme for more instructions):
/cc @csboling
Partially fixes #11