Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DTO ID to be able to have custom IDs #178

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Use DTO ID to be able to have custom IDs #178

merged 1 commit into from
Aug 11, 2023

Conversation

maximehuran
Copy link
Member

@maximehuran maximehuran commented Aug 11, 2023 •
edited
Loading

Be able to use custom method in DTO like :

    public function getId(): string
    {
        return sprintf('%s_%s', $this->getType(), $this->getObjectId());
    }

We not break the default behaviour :

image

And user be able to customize their DTO IDs

@maximehuran maximehuran marked this pull request as ready for review August 11, 2023 14:16
@delyriand delyriand merged commit a890099 into monsieurbiz:master Aug 11, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delyriand delyriand delyriand approved these changes

Assignees
No one assigned
Labels
quick win Status: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximehuran @delyriand @madamebiz