Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement fixtures #60

Merged
merged 34 commits into from
Jul 26, 2023
Merged

Implement fixtures #60

merged 34 commits into from
Jul 26, 2023

Conversation

jacquesbh
Copy link
Member

@jacquesbh jacquesbh commented Jul 24, 2023 •
edited
Loading

We just implemented the fixtures 🔥.

fixes #57

jacquesbh and others added 24 commits July 24, 2023 10:26
@jacquesbh
feat(fixtures): Add yaml fixtures into test app configuration
57ea789
@jacquesbh
doc(fixtures): Update readme
84e09ec
@etienne-monsieurbiz
feat: init fixture files
d3e8cc3
@jacquesbh
chore(fixtures): reformat
29b076e
@jacquesbh
feat(fixtures): Channel and locale can be empty values
36c06b4
@jacquesbh
chore(readme): Update badges
8a7b2d2
@jacquesbh
feat(fixtures): Add two more fixtures in test application
8bee774
@etienne-monsieurbiz
feat(fixture): Add fixture factory
2dd6032
@jacquesbh
feat(fixtures): Use factory
11a7ac0
@etienne-monsieurbiz
feat(fixture): DI for autowiring
4a7d86d
@jacquesbh
feat(fixtures): Configure options
2384626
@jacquesbh
fix(fixtures): Use keys in list
25a3536
@jacquesbh
feat(fixtures): Add more default value for testing purposes
8e1622d
@etienne-monsieurbiz
feat(fixture): add setAllowedType in fixture factory
d0b0b9a
@jacquesbh
feat(fixtures): Format value according to type
0dadf89
@etienne-monsieurbiz
fix(fixtures): AllowedType for value and AllowedValues for type
a090dc1
@etienne-monsieurbiz
refactor(fixtures): Use constants for setAllowedValues
4a65196
@jacquesbh
fix(fixtures): Json values are properly formated
a6eb28b 
I also included a refactoring of the format section.
@jacquesbh
feat(fixtures): Run only local suite
1089122
@jacquesbh
doc(fixtures): Add local fixtures sentence
6d50972
@etienne-monsieurbiz
refactor(fixture): phpcs fix
798ca7c
@etienne-monsieurbiz
fix: error phpcs phpstan
374edd5
@jacquesbh
feat(fixtures): Update values instead of adding new ones
c6dd356
@etienne-monsieurbiz
fix: MakeFile to setup messenger
0a3047d
@madamebiz madamebiz added the Status: needs review Needs review label Jul 24, 2023
@jacquesbh jacquesbh marked this pull request as ready for review July 24, 2023 10:46
@jacquesbh jacquesbh added the enhancement New feature or request label Jul 24, 2023
@jacquesbh jacquesbh mentioned this pull request Jul 24, 2023
Closed
@etienne-monsieurbiz etienne-monsieurbiz mentioned this pull request Jul 24, 2023
Merged
jacquesbh
jacquesbh commented Jul 24, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
src/Command/SetSettingsCommand.php Show resolved Hide resolved
src/Command/SetSettingsCommand.php Outdated Show resolved Hide resolved
src/Command/SetSettingsCommand.php Outdated Show resolved Hide resolved
src/Fixture/Factory/SettingsFixtureFactory.php Outdated Show resolved Hide resolved
src/Formatter/SettingsFormatter.php Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jacquesbh
jacquesbh commented Jul 25, 2023
View reviewed changes
Copy link
Member Author

@jacquesbh jacquesbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@etienne-monsieurbiz etienne-monsieurbiz merged commit 0452d8d into monsieurbiz:master Jul 26, 2023
14 checks passed
@jacquesbh jacquesbh deleted the fixtures branch July 26, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etienne-monsieurbiz etienne-monsieurbiz etienne-monsieurbiz approved these changes

@maximehuran maximehuran maximehuran approved these changes

@delyriand delyriand Awaiting requested review from delyriand

Assignees
No one assigned
Labels
enhancement New feature or request Status: needs review Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Be able to set default value on the channel
4 participants
@jacquesbh @maximehuran @etienne-monsieurbiz @madamebiz