Montage data converters#1 #2010

marchant · 2019-02-12T08:11:02Z

To merge after /feature/npm3

Adds a new new converter to map embedded types
fixes a deserialization bug
adds resolveObjectForTypeRawData method to RawDataService

it is deserialized as the root of a serilization

in expression data mappings

- adds a future-proof way to get a type's prototype & constructor

it is deserialized as the root of a serilization

in expression data mappings

- adds a future-proof way to get a type's prototype & constructor

to undefimed revertExpression

to asynchronously retrieve a fully mapped object

…ge into montage-data-converters#1

cdebost

Needs to be linted.

Looks like some commits got added twice, this PR should be rebased to remove duplicates.

I'll let @tejaede review the data/ related changes.

core/serialization/deserializer/montage-reviver.js

data/service/data-service.js

data/converter/expression-data-mapping-converter.js

data/service/raw-data-service.js

data/converter/raw-embedded-value-to-object-converter.js

tejaede

Can we find a more descriptive name than than ExpressionDataMappingConverter? The name says the converter can be used in ExpressionDataMapping objects, but that is true for any object that implements the converter interface so it doesn't tell us much.

The class and its subclasses do something very specific -- use rawData of type Foo to fetch (or create) cooked objects of type Bar where Bar is a level 1 montage-data type -- so we should find a name that reflects that, IMO.

Some options:

RawValueToObjectConverter -- The obvious parent class name for the two subclasses (RawEmbeddedValueToObjectConverter and RawPropertyValueToObjectConverter), both of which are well named, IMO.
ForeignKeyConverter -- the object (and its subclasses) are responsible for most, if not all, foreign keys so this would be apt as well. This would break the association of parent class name to child class name that we would get with # 1.
RawValueToForeignKeyConverter -- combination of # 1 and # 2.

marchant · 2019-02-19T01:26:10Z

Agreed, how about parent: RawValueToObjectConverter
then RawEmbeddedValueToObjectConverter and 1. RawForeignValueToObjectConverter ?

marchant · 2019-02-19T02:44:43Z

refactor/add convertDataQuery and revertDataQuery to adds more transparency and allow upper layers to expose that query.

If they can't be loaded from the app package, they will be retried under mr (npm 2 / legacy bundling support).

I suspect this code only exists for historical reasons, but it seems totally unnecessary, as bluebird will already be cached in the registry and will not be loaded twice. The hardcoded bluebird path causes an extra 404 when loading the app with npm 3+.

it is deserialized as the root of a serilization

in expression data mappings

- adds a future-proof way to get a type's prototype & constructor

marchant · 2019-04-01T02:27:47Z

This merged the latest in #master to get sync capabilities in the deserializer, and it needs montagejs/mr#146 to work, which is itself additional to the npm3 work, so both PR go hand in hand

marchant · 2019-04-01T02:30:11Z

montage tests pass, also tested with a montage data improved version of shop-demo (which wasn't working without these changes as it's the first use of a main.datareel folder that contains all data related assets) as well as Popcorn master. Please review again.

marchant · 2019-04-01T05:24:52Z

Some test fails as it needs montagejs/mr#146, I didn't change package.json, so it still points to "18.0.0-rc1" where montagejs/mr#146 needs to be merged on

tejaede · 2019-04-09T23:00:58Z

core/meta/module-object-descriptor.js

@@ -60,6 +60,9 @@ var ModuleObjectDescriptor = exports.ModuleObjectDescriptor = ObjectDescriptor.s
            this.super(serializer);
            this._setPropertyWithDefaults(serializer, "module", this.module);
            this._setPropertyWithDefaults(serializer, "exportName", this.exportName);
+            if(this.object) {
+                this._setPropertyWithDefaults(serializer, "object", this.object);


@marchant Is there a spec for serializing/deserializing ModuleObjectDescriptor#object?

tejaede · 2019-04-10T02:56:10Z

An error with DataService deserialization bubbled up some inconsistencies.

DataService._childServices is designed to be a Set, per the documentation. However, DataService.deserializeSelf set the value to an array.
DataService.deserializedFromSerialization called DataService.addChildServices with DataService._childServices. As mentioned above, DataService._childServices is an Array if the serialization includes child services, but is a Set if the value is allowed to lazy load.

I am unable to write to marchant/montagejs so I pushed fixes to my own repo for these issues for your review: tejaede@9829912

The fixes are:

Ensure DataService.childServices is always a set
Use iterator in DataService.addChildServices so the argument can be either a Set or an Array

cc: @marchant

…s objectDescriptorModule as a dependency. This could be made more general but slower for all {“%”: “module_id”} construction in a serialization

Makes sure all child services are added and only once.

Adds ability to deserialize synchronously objetc descriptor references: - in expression-data-mapping.js - in raw-value-to-object-converter.js

…ge into montage-data-converters#1

… fix build no running

marchant · 2019-08-11T04:24:44Z

There's a problem running karma on travis, we need to fix this independently of this PR, merging.

marchant added 12 commits February 10, 2019 18:09

Allows an object to receive deserializedSelf every time

9592b13

it is deserialized as the root of a serilization

Creates a new root class for converters dedicated to be used

63ccacf

in expression data mappings

- _addChildService can be called several times without side effects

8a2bd24

- adds a future-proof way to get a type's prototype & constructor

Adds a new converter to create embedded full objects of the right type

6191519

Allows an object to receive deserializedSelf every time

ccb1603

it is deserialized as the root of a serilization

Creates a new root class for converters dedicated to be used

de359b4

in expression data mappings

- _addChildService can be called several times without side effects

bafd719

- adds a future-proof way to get a type's prototype & constructor

Adds a new converter to create embedded full objects of the right type

63fe025

- Makes revertSyntax, compiledRevertSyntax more robust

8f63f2c

to undefimed revertExpression

adds resolveObjectForTypeRawData method

57c7766

to asynchronously retrieve a fully mapped object

- fixes bugs

62563b0

Merge branch 'montage-data-converters#1' of github.com:marchant/monta…

291d4d8

…ge into montage-data-converters#1

marchant requested review from cdebost and tejaede February 12, 2019 08:11

cdebost previously requested changes Feb 12, 2019

View reviewed changes

tejaede reviewed Feb 12, 2019

View reviewed changes

cdebost and others added 12 commits February 22, 2019 16:13

Bootstrap scripts from main app package

b3b1f4b

If they can't be loaded from the app package, they will be retried under mr (npm 2 / legacy bundling support).

Use mr#feature/npm3

620b811

Fix bad mainPackageLocation in getMontageDeserializer

10c74d5

Enable node 6, 8, 10 in travis

75be71f

Remove legacy bundling option from travis

f8dd5df

Run integration with mop#feature/npm3

c2323d9

Bump version to 18.0.0-rc1

099766b

Allows an object to receive deserializedSelf every time

19d947c

it is deserialized as the root of a serilization

Creates a new root class for converters dedicated to be used

e582eac

in expression data mappings

- _addChildService can be called several times without side effects

023d207

- adds a future-proof way to get a type's prototype & constructor

Adds a new converter to create embedded full objects of the right type

fa5d2a6

Fixes jslint warnings

62fea61

tejaede reviewed Apr 9, 2019

View reviewed changes

marchant added 22 commits August 5, 2019 17:00

adds the ability to process the value of object-descriptor-reference’…

39dedf9

…s objectDescriptorModule as a dependency. This could be made more general but slower for all {“%”: “module_id”} construction in a serialization

Backward compatibility improvement.

4687575

Makes sure all child services are added and only once.

Exposes isSync API on deserializer, interpreter & reviver

8220b11

Adds ability to deserialize synchronously objetc descriptor references: - in expression-data-mapping.js - in raw-value-to-object-converter.js

Updates version to rc2 and engines dependencies

e1b7a02

Updates node version for lint

7f787c6

Merge branch 'master' into montage-data-converters#1

0a8082e

Fix for xvfb issue

9523eae

Merge branch 'montage-data-converters#1' of github.com:marchant/monta…

33cbde8

…ge into montage-data-converters#1

Removes committed version of package-lock.json

f64754c

Use node 8+ for tests

7ce7367

Specify node 8 and 10 for test stage

b24833b

Removes tests with node 4 and 6

2cecdba

Adds missing spec files

f134bd6

Updates mr dependency to fix tests

6fa2ca2

Updates Karma dependencies to run on node 8+

dfc03a4

Updates base node version to 10

a7f661e

Changing Karma to connect to the xvfb display on DISPLAY=:0 to try to…

4217a32

… fix build no running

Adds browserSocketTimeout to attempt to fix karma tests on travis

b1f070f

Updates browserSocketTimeout to 80000

a7b20ff

Change to try to get travis test to run in Chrome

87cdea7

reverts to node 8 for travis tests

0444552

Comments use of process.env as process is undefined??

ccb6fcf

marchant merged commit 0246d8a into montagejs:master Aug 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Montage data converters#1 #2010

Montage data converters#1 #2010

marchant commented Feb 12, 2019

cdebost left a comment

tejaede left a comment •

edited

Loading

marchant commented Feb 19, 2019

marchant commented Feb 19, 2019

marchant commented Apr 1, 2019

marchant commented Apr 1, 2019

marchant commented Apr 1, 2019

tejaede Apr 9, 2019

tejaede commented Apr 10, 2019

marchant commented Aug 11, 2019

Montage data converters#1 #2010

Montage data converters#1 #2010

Conversation

marchant commented Feb 12, 2019

cdebost left a comment

Choose a reason for hiding this comment

tejaede left a comment • edited Loading

Choose a reason for hiding this comment

marchant commented Feb 19, 2019

marchant commented Feb 19, 2019

marchant commented Apr 1, 2019

marchant commented Apr 1, 2019

marchant commented Apr 1, 2019

tejaede Apr 9, 2019

Choose a reason for hiding this comment

tejaede commented Apr 10, 2019

marchant commented Aug 11, 2019

tejaede left a comment •

edited

Loading