-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event listener evolution to new standard supporting options object as third argument #2030
Open
marchant
wants to merge
415
commits into
montagejs:master
Choose a base branch
from
marchant:addEventListener-evolution
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- first working version of requiring es files with import/export - slight improvement in xhr use for loading
- fix collections set require
to improve bindability
- Tweak requires
- Fix isSearchable default
- add missing descriptor
…o it can be shared shared between setting expression and syntax.
…parsing the definition expression
…a if it's not included by server and they are known client side, before processing as usual
- move failsafe against fetching object properties of created objects from DataTrigger to DataService, allowing more finesse for fetching properties of newly created objects that can based on their current values set, still preventing cases where a typical primary key would be involved in the fetch - makes isObjectCreated more robust to just using this.createdDataObjects as some promises now involved in fetching object, properties because it's not done at the DataTrigger level, can fire after a saveChanges() may have wiped this.createdDataObjects - improve/fix bug dealing with mapping added/removed values - add method to create a criteria that supports compound primaryKeys - add ability for foreign value converter to work for properties, including if fetch depend on the values of other properties of the same object. Add readExpression to query in that case so RawDataService involved has a cue
…or, with the ability to call .next(aType) to move through the tree with more finesse. Because syntax is built by the parser generated by Peg, we don't have a type where we could get the iterator from.
…ilar events on objects, like 'create'
that impacts every listeners dispatched after handleOrganizedContentRangeChange because it modifies the passed argument.
…EventListener. Performance comparison with master are needed.
…do rather than doing upfront before we know wether there are listeners or not.
…rce and a drag destination registered
marchant
force-pushed
the
addEventListener-evolution
branch
from
February 15, 2021 05:50
9b271b1
to
f20960b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.