Bugfix: set active navigation node when smartmenus are enabled, resoves #620, #384 and #694. #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with other primary navigation Fixed moodle-an-hochschulen#344 and moodle-an-hochschulen#620
… with associative arrays.
|
Something I am not completely happy with concerning the tests which is way I select the smartmenu top level menu items: There seems to be no way to set the data-key for the smartmenus. Maybe one should be auto-generated by the title/text. Or is there a smarter more robust solution concerning the tests? |
Menrath
changed the title
This was
linked to
issues
Oct 2, 2024
…olved thanks @wiebkemueller-hsh for linking these issues
Menrath
changed the title
|
The behat tests now fail for the newest MOODLE_404_STABLE, but I think the issue is not related with this PR. |
abias
force-pushed
the
main
branch
3 times, most recently
from
5696e9a
to
b9fa4ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another summer time theme_boost_union fix.
This targets at solving the issues #620, #384 and #694.
In the file
classes/output/navigation/primary.phpwhen smartmenus were enabled theparent:export_for_templatedoes not get called ( parent class iscore\navigation\output\primary).Cause of the bug: The menu with the smartmenu nodes are just merged with the primary navigation and the custommenus via the PHP function
array_merge.Fix: Now the smartmenus and the custommenus are merged via array_merge and later merged with the primary menu nodes via the function
merge_primary_and_custom. This function checks for the active node, the same way it happens when smartmenus are disabled.Maybe this should also be adjusted when the variable
$mobileprimarynavgets set, too.To-Do:
At reviewers:
There is still a bug when clicking on external static link in the smartmenu and using the browsers return function, that multiple nodes (the actual active one and the external one) are shown as active. But I don't have any idea how to fix this edge case.