Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending navbar logo settings with maxwidth - resolves #544 #659

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DocDanouBot
Copy link

On behalf of the Boost Union Team: 🎉 Thank you for contributing! 🎉

Please note: There must be a GitHub issue for every pull request (PR)

We kindly ask you to create a github issue now if you haven't already done so.

Please make sure to follow these steps to ease the review process for the peer review team:

[ ] link your issue in the PR title, using the keyword 'resolves #ISSUE-NUMBER', e.g. 'Feature: Provide the ultimate user experience, resolves #42'
[ ] provide any further information that is relevant for peer review and not yet mentioned in the linked issue as a comment in the PR
[ ] make sure that the 'Allow edits by maintainers' checkbox is checked when creating the PR. Otherwise, the peer reviewer would not be able to push any review changes to the PR and the communication overhead increases
[ ] submit your PR in draft status to run the automated checks and review the results
[ ] in case any checks fail solve the mentioned errors by pushing the corrected code to your PR-branch
[ ] if all checks pass (or if you are unable to resolve the failing steps without any help of the review team), mark the PR as 'ready for review'

Thank you again for your contribution, we will start reviewing your PR as soon as we are able to.

In the meantime, please check our wiki page for creating pull requests and our wiki page for reviewing pull requests for further infomation about our contribution and review process.

@DocDanouBot DocDanouBot marked this pull request as ready for review May 17, 2024 08:06
@abias abias linked an issue May 18, 2024 that may be closed by this pull request
@abias abias force-pushed the main branch 3 times, most recently from 5696e9a to b9fa4ca Compare October 21, 2024 15:33
@abias abias force-pushed the ISSUE-544-extending_logo_settings_with_maxwidth branch from 1cd1826 to 018ed8a Compare October 26, 2024 12:51
@abias
Copy link
Member

abias commented Oct 26, 2024

Hi @DocDanouBot,

thank you very much for working on this issue.

I just rebased your branch onto the latest main branch and reviewed your PR.
The general functionality works like a charm. I just had to make some review changes to align the feature with BU's general coding style and structure.

Regarding the integration of the PR, I would like to wait for a fix for #733 as - depending on the solution there - this PR might need some additional modification.

Cheers,
Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement: Add admin setting for logo max-width in the navbar
3 participants