Sort comments by timeposted AND id to avoid random behat failures #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, the order comments are displayed in can be random if they're posted at the exact same second (as generally happens in behat testing). This causes a problem for the behat test when it just goes to delete the second comment on the page, assuming they're in order. This likely doesn't affect mysql, but definitely does affect pgsql.
aolley
force-pushed
the
random_failure
branch
from
a2d9dd7
to
bccc093
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, the order comments are displayed in can be random
if they're posted at the exact same second (as generally happens in
behat testing). This causes a problem for the behat test when it just
goes to delete the second comment on the page, assuming they're in
order.
This likely doesn't affect mysql, but definitely does affect pgsql.