Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart contracts whitelist #169

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

augustocollado
Copy link
Contributor

@augustocollado augustocollado commented Jun 26, 2024

Description

This PR adds a guide to whitelisting smart contracts deployment using polkadot js

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this page requires a disclaimer, I have added one
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects

@augustocollado augustocollado added the A0 - New Content Pull request contains new content pages label Jun 26, 2024
Copy link
Collaborator

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Minor grammar corrections.

@@ -8,4 +8,5 @@ nav:
- 'Pause Transactions': 'pause-transactions.md'
- 'Impersonate Accounts': 'impersonate.md'
- 'Mint Tokens': 'minting.md'
- 'Smart EVM - Whitelist Smart Contracts Deployment': 'smart-contracts-creation-filter.md'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 'Smart EVM - Whitelist Smart Contracts Deployment': 'smart-contracts-creation-filter.md'
- 'Whitelist Smart Contracts Deployers': 'smart-contracts-creation-filter.md'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After rendering the page it does not look that bad. @eshaben what do you think?

image

Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just small things 🙂

builders/manage/developer-portal/.pages Outdated Show resolved Hide resolved
builders/manage/developer-portal/.pages Outdated Show resolved Hide resolved
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨

@augustocollado augustocollado merged commit b8a2980 into main Jun 26, 2024
1 check passed
@augustocollado augustocollado deleted the augustocollado/smart-contracts-deploy-filter branch July 2, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0 - New Content Pull request contains new content pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants