Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Builders-substrate-adding built in module article #22

Merged
merged 28 commits into from
Sep 8, 2023

Conversation

augustocollado
Copy link
Contributor

Description

This PR adds a subsection "substrate" in Builders with an article covering how to add a built in module to the frontier template included in tanssi

Checklist

  • If this page requires a disclaimer, I have added one
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects

Copy link
Collaborator

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Generally speaking it would be great to a see just a tiny bit of explaining for each code snippet. This feels more like a "follow and don't understand anything you are doing" guide than explaining things (at a high level)

builders/build/substrate/adding-built-in-pallet.md Outdated Show resolved Hide resolved
builders/build/substrate/adding-built-in-pallet.md Outdated Show resolved Hide resolved
builders/build/substrate/adding-built-in-pallet.md Outdated Show resolved Hide resolved
builders/build/substrate/adding-built-in-pallet.md Outdated Show resolved Hide resolved
builders/build/substrate/adding-built-in-pallet.md Outdated Show resolved Hide resolved
builders/build/substrate/adding-built-in-pallet.md Outdated Show resolved Hide resolved
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just little grammar nitpicks. One thing to note is that all items wrapped in triple back ticks should have a language next to them. For contract addresses, file names, etc. you can use text as the language

There is an index page icon missing for "Adding a Built-in Module" (http://127.0.0.1:8000/builders/build/substrate/)

builders/build/substrate/.pages Outdated Show resolved Hide resolved
builders/build/substrate/adding-built-in-pallet.md Outdated Show resolved Hide resolved
builders/build/substrate/adding-built-in-pallet.md Outdated Show resolved Hide resolved
builders/build/substrate/adding-built-in-pallet.md Outdated Show resolved Hide resolved
builders/build/substrate/adding-built-in-pallet.md Outdated Show resolved Hide resolved
builders/build/.pages Outdated Show resolved Hide resolved
builders/build/substrate/index.md Outdated Show resolved Hide resolved
builders/build/substrate/index.md Outdated Show resolved Hide resolved
builders/build/substrate/adding-built-in-pallet.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 1 minor comment but otherwise looks good.

Create a ticket to restructure this content once we have the new flow of everything being based of Tanssi templates with the new Prerequisites that Devs need to have a Tanssi template running or something

builders/build/substrate/adding-built-in-pallet.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, left some minor feedback, feel free to include it and merge it 🙌

builders/build/substrate/adding-built-in-pallet.md Outdated Show resolved Hide resolved
builders/build/substrate/adding-built-in-pallet.md Outdated Show resolved Hide resolved
builders/build/substrate/adding-built-in-pallet.md Outdated Show resolved Hide resolved
builders/build/substrate/adding-built-in-pallet.md Outdated Show resolved Hide resolved
Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@albertov19 albertov19 merged commit a7622b9 into main Sep 8, 2023
1 check passed
@albertov19 albertov19 deleted the augustocollado/builders-basic-substrate branch September 8, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants