-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Builders-substrate-adding built in module article #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Generally speaking it would be great to a see just a tiny bit of explaining for each code snippet. This feels more like a "follow and don't understand anything you are doing" guide than explaining things (at a high level)
Co-authored-by: albertov19 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just little grammar nitpicks. One thing to note is that all items wrapped in triple back ticks should have a language next to them. For contract addresses, file names, etc. you can use text
as the language
There is an index page icon missing for "Adding a Built-in Module" (http://127.0.0.1:8000/builders/build/substrate/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 1 minor comment but otherwise looks good.
Create a ticket to restructure this content once we have the new flow of everything being based of Tanssi templates with the new Prerequisites that Devs need to have a Tanssi template running or something
Co-authored-by: albertov19 <[email protected]>
.snippets/code/basic-substrate/built-in-pallet-configuration.rs
Outdated
Show resolved
Hide resolved
.snippets/code/basic-substrate/built-in-pallet-configuration.rs
Outdated
Show resolved
Hide resolved
.snippets/code/basic-substrate/built-in-pallet-configuration.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, left some minor feedback, feel free to include it and merge it 🙌
Co-authored-by: albertov19 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Description
This PR adds a subsection "substrate" in Builders with an article covering how to add a built in module to the frontier template included in tanssi
Checklist
moonbeam-mkdocs
to update redirects