Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethers.js with Erin's feedback #25

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Conversation

albertov19
Copy link
Collaborator

Description

This just adds Erin's Feedback to the Ethers.js PR

Checklist

  • If this page requires a disclaimer, I have added one
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects

Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@augustocollado augustocollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@albertov19 albertov19 merged commit 9a25321 into main Sep 5, 2023
1 check passed
@albertov19 albertov19 deleted the albertov19/eth-libraries branch September 5, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants