Builders - adding a custom made module #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertov19
requested changes
Sep 5, 2023
|
|
||
| The `#[pallet::storage]` macro initializes a runtime storage structure. In this example, a basic value storage structure is used to persist the list of participants in a bounded capacity vector ([BoundedVec](https://crates.parity.io/frame_support/storage/bounded_vec/struct.BoundedVec.html){target=_blank}). | ||
|
|
||
| In the heavily constrained environment of an AppChain, deciding what to store and which structure to use can be critical in terms of performance. More on this topic is covered in the [Substrate documentation](https://docs.substrate.io/build/runtime-storage/){target=_blank}. |
There was a problem hiding this comment.
Appchain or ContainerChain?
There was a problem hiding this comment.
Uhmm, It's a general statement, situated in a design phase I'd use Appchain
Co-authored-by: albertov19 <[email protected]>
eshaben
reviewed
Sep 6, 2023
albertov19
approved these changes
Sep 7, 2023
Co-authored-by: albertov19 <[email protected]>
albertov19
reviewed
Sep 8, 2023
albertov19
approved these changes
Sep 8, 2023
Co-authored-by: albertov19 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the builders/add custom module article along with its associated code snippets
It also updates the code previously added of the module, updating comments and line breaks to avoid horizontal scrollbars
Feedback regarding clarity will be much appreciated :)
Shortcomings:
Checklist
moonbeam-mkdocsto update redirects