Improve 3DS Reliability #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgutman
reviewed
Feb 2, 2024
cgutman
reviewed
Feb 2, 2024
src/PlatformSockets.c
Outdated
| Limelog("Set rcv buffer size failed: %d\n", err); | ||
| closeSocket(s); | ||
| SetLastSocketError(err); | ||
| return INVALID_SOCKET; |
There was a problem hiding this comment.
We don't want this error to be a hard failure.
There was a problem hiding this comment.
Alright, I wasn't sure whether or not it should be an error for other platforms. I think it's a good idea to the limelog print though, since it causes some serious stability issues on the 3DS that are otherwise kinda hard to find if it fails.
|
Can you rebase this PR to get rid of those commits that touch the enet submodule? Those prevent the PR from being mergeable through the GitHub UI. |
Reduce thread stack sizes (match vita) Set a maximum receive buffer size for 3DS sockets Remove global socket setting
zoeyjodon
force-pushed
the
zjodon/optimize-poll
branch
from
a272260
to
acd1f0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This MR improves moonlight's reliability on the 3DS, mostly around socket connections. Since adding these changes, the 3DS app went from crashing within minutes of connecting to the server to being able to hold a stable connection with the host for hours on end.
Changelog