Skip to content

Commit

Permalink
Migration to latest jupyter version
Browse files Browse the repository at this point in the history
  • Loading branch information
Mani-D committed Jun 9, 2024
1 parent f99242f commit 827dfdf
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
3 changes: 2 additions & 1 deletion scripts/lib/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@
'cement',
'termcolor',
'py-cpuinfo',
'jupyter',
'nbclassic',
'six',
'setuptools'
],
zip_safe=False)
4 changes: 2 additions & 2 deletions scripts/lib/xpedite/jupyter/commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"""

import logging
from IPython.core.display import display, HTML
from IPython.display import display, HTML

Check warning on line 17 in scripts/lib/xpedite/jupyter/commands.py

View check run for this annotation

Codecov / codecov/patch

scripts/lib/xpedite/jupyter/commands.py#L17

Added line #L17 was not covered by tests
from xpedite.jupyter.context import context
from xpedite.report.markup import ERROR_TEXT

Expand Down Expand Up @@ -241,7 +241,7 @@ def __repr__(self):
) if self.profile.current.isEventsEnabled() else ''
threshold = 1000
if len(self.profile.current) > threshold:
LOGGER.warn('too many transaction - showing only %d out of %d', threshold, len(self.profile.current))
LOGGER.warning('too many transaction - showing only %d out of %d', threshold, len(self.profile.current))

Check warning on line 244 in scripts/lib/xpedite/jupyter/commands.py

View check run for this annotation

Codecov / codecov/patch

scripts/lib/xpedite/jupyter/commands.py#L244

Added line #L244 was not covered by tests
strRepr += str(ReportBuilder().buildTimelineTable(
self.profile.current, self.profile.probes, ResultOrder.Chronological, threshold, uid
))
Expand Down
2 changes: 1 addition & 1 deletion scripts/lib/xpedite/jupyter/driver.py
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ def launchJupyter(homeDir):
jupyterEnv['PATH'] = pyPath
jupyterEnv['HOME'] = tempfile.mkdtemp(prefix=SHELL_PREFIX, dir='/tmp')
jupyterBinary = binPath('jupyter')
os.execle(jupyterBinary, 'Xpedite', 'notebook', '--no-browser', '--notebook-dir='+homeDir, jupyterEnv)
os.execle(jupyterBinary, 'Xpedite', 'nbclassic', '--no-browser', '--notebook-dir='+homeDir, jupyterEnv)

Check warning on line 213 in scripts/lib/xpedite/jupyter/driver.py

View check run for this annotation

Codecov / codecov/patch

scripts/lib/xpedite/jupyter/driver.py#L213

Added line #L213 was not covered by tests

def validatePath(homeDir, reportName):
"""Validates the path to store xpedite notebook and data files"""
Expand Down
5 changes: 3 additions & 2 deletions scripts/lib/xpedite/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ netifaces>=0.10.4
numpy>=1.15.2
pygments>=2.0.2
rpyc>=4.0.1
cement==2.8.2
cement>=3.0.10
termcolor>=1.1.0
py-cpuinfo>=0.1.2
jupyter>=1.0.0
six>=1.12.0
nbclassic>=1.0.0
setuptools

0 comments on commit 827dfdf

Please sign in to comment.