Add BINLOG_ADAPT_CONCEPT #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Clang, because GitHub Ubuntu latest image has gcc 9, that does not support concepts. clang 10 should have a better support. - https://gcc.gnu.org/projects/cxx-status.html - https://clang.llvm.org/cxx_status.html
|
CI fails because of toolchain issue / CMake fails to detect that LTO will not work. (see #136) Finally there's a repro - so I can fix that as well : ) |
|
Also fixes #136 |
|
Looks good. Templated concepts might also be an interesting challenge. |
|
@spektrof ptal and merge. Thanks! |
spektrof
approved these changes
Sep 23, 2022
If you have a use-case, please file a ticket with an example that shows "exactly" what you are looking for - and I'll get there eventually : ) thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150 . @andrewkcorcoran please take a look.