-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add strict mode #86
base: master
Are you sure you want to change the base?
feat: add strict mode #86
Conversation
currently used for toggling compromised lock behaviour
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
===========================================
+ Coverage 98.29% 100.00% +1.70%
===========================================
Files 4 6 +2
Lines 176 205 +29
Branches 45 50 +5
===========================================
+ Hits 173 205 +32
+ Misses 3 0 -3
Continue to review full report at Codecov.
|
@pimlie I would prefer to not add any option and actually make this the default. This means that the PR would be much simpler by just changing this to not throw: node-proper-lockfile/lib/lockfile.js Line 240 in c0cdea2
|
@satazor What about still removing the lock when its compromised? I guess you are opposed to that? The reason I added it because I actually like the idea that both processes will generate a warning untill we figured out why the lock was compromised in the first place. |
If the lock has been compromised, it usually means that someone else got the lock. It would be bad to delete the lock in that situation. |
feat: dont trigger error on compromised lock
Updated as requested :) |
Ref: #81
Strict mode is currently only used for toggling compromised lock behaviour