Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1517996 - Add a link back to the user's profile from the Activity Report page #1523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KWierso
Copy link
Contributor

@KWierso KWierso commented Mar 6, 2020

@@ -322,6 +322,8 @@ sub report {
$vars->{'incomplete_data'} = $incomplete_data;
$vars->{'operations'} = \@operations;

$vars->{user} = Bugzilla::User->new({ name => $input->{who}, cached => 1 });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inside the for loop that stores each activity item. So depending on how many activity rows there are, it will be set each time. Also user_activity.html allows for displaying more than one person grouped together. Normally from user_profile.html, the link to user_activity.html would only be a single person so wouldn't be an issue with that case. But we need to be able to handle both cases.

So out side of the for loop you need to create $var->{users}:

$var->{users}
  = [ map { Bugzilla::User->new({ name => $_, cache => 1}) } @who ];

@@ -104,6 +104,10 @@
</p>
[% END %]

<p>
<a href="[% basepath FILTER none %]user_profile?user_id=[% user.id FILTER uri %]"> User Profile</a>
</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to deal with the possibility that multiple users were searched on instead of always coming from user_profile.html so we may need a loop here:

<p>
  User Profiles:
  [% FOREACH u = users %]
    <a href="[% basepath FILTER none %]user_profile?user_id=[% u.id FILTER uri %]">[% user.name FILTER html %]</a>[% ", " IF NOT loop.last() %]
  [% END %]
</p>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants