Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1536547 add link under poked bugs count #1537

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aquaruiz
Copy link

As an Outreachy applicant, I fixed bug 1536547 - The counter for "Bugs Poked" in User Profile is made a link. I did the query string according bugzilla advanced search form - option search by authors.

<td class="numeric">
[% IF user.id %]
<a href="[% basepath FILTER none %]buglist.cgi?query_format=advanced&amp;emailtype1=exact&amp;emailqa_contact1=1&amp;emailassigned_to1=1&amp;emaillongdesc1=1&amp;emailbug_mentor1=1&amp;emailreporter1=1&amp;email1=[% target.login FILTER uri %]"
target="_blank">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we don't open links in new tabs/windows since the user can always right- or control-click.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix this.

@emceeaich emceeaich requested a review from dklawren March 22, 2020 20:33
@dklawren dklawren requested a review from emceeaich March 23, 2020 20:07
Copy link
Collaborator

@dklawren dklawren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The query string is incorrect for the type of data that 'Bugs poked' represents. The bugs poked count is the number if bugs that the user has made a change or commented on and is not necessarily a bug they are assigned to, reporter, or qa contact for. This is the query used to get the bugs poked count.

SELECT COUNT(*) FROM (
    SELECT bugs_activity.bug_id
      FROM bugs_activity
     WHERE who = ?
     GROUP BY bugs_activity.bug_id
    UNION
    SELECT longdescs.bug_id
      FROM longdescs
     WHERE who = ?
     GROUP BY longdescs.bug_id
) temp

Probably needs to be more like this:

https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&f2=commenter&v1=[% target.login FILTER uri %]&o2=equals&f1=anything&j_top=OR&v2=[% target.login FILTER uri %]&o1=changedby

@aquaruiz
Copy link
Author

aquaruiz commented Mar 24, 2020

I am a little confused. I cannot find what is changedBy. According Bugzilla automatic emailing service, user - bug interactions are as following:

image

Is it possible poked count to be related to bug's reporter, assignee and commenter?

@dklawren
Copy link
Collaborator

I am a little confused. I cannot find what is changedBy. According Bugzilla automatic emailing service, user - bug interactions are as following:

image

Is it possible poked count to be related to bug's reporter, assignee and commenter?

Sorry for the confusion. The URL I posted as an example comes from the Advanced Search page and is used for finding existing bugs in the system. The screenshot you posted is from a users email preferences where a user can customize what kind of notifications they get via email.

If you go to https://bugzilla.mozilla.org/query.cgi and look at the bottom you should see a section at the bottom where the special search terms can be created:

image

If you click this link you should see the values filled in that I suggest:

https://bugzilla.mozilla.org/query.cgi?query_format=advanced&f2=commenter&[email protected]&o2=equals&f1=anything&j_top=OR&[email protected]&o1=changedby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants