Skip to content
This repository has been archived by the owner on Feb 7, 2019. It is now read-only.

Add landing page create button #337

Closed

Conversation

henryhahn
Copy link
Contributor

This PR adds a button to the landing page for being able to directly add a new entry.

This is meant to start implementing the designs associated with #293.

screenshot 2017-11-14 01 10 20

@@ -18,6 +18,8 @@ welcome-feedback =
button within the tool, including any issues you may find, things
you like, and the things you're looking forward to in the future.

welcome-add-item = Create Entry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this string used somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Removed.

Copy link
Contributor

@jimporter jimporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't where the spec puts the button; according to the spec, it goes in the list on the left. I still need to discuss this a bit more before we make any changes to this area though...

@henryhahn
Copy link
Contributor Author

Hey @jimporter - I'm looking at the mocks linked in the bug: https://mozilla.invisionapp.com/share/MHEBCD4PK#/screens/262155636

It does look to me like its meant to happen here below the fold. Do you mind clarifying what you mean?

@devinreams
Copy link
Contributor

devinreams commented Nov 14, 2017

Thanks for the contributions thus far, @henryhahn!

Right now @changecourse (our UX expert and designer) is re-imaginging some of the flows from "first run" through to "coming back to a welcome screen" (aka landing page) and what those should be to guide the user's experience. Long story short: we have a lot of moving parts and the designs aren't all ready quite yet.

We expect some explicit requirements (in the form of a new issue or updates to #292) to come soon to help clearly describe what we want to change. Stay tuned!

@jimporter
Copy link
Contributor

@henryhahn The mockup you linked shows different buttons on the homepage than the one you added. Based on the mockup, we plan to put buttons there to set up a Firefox Account for sync/master password stuff. The button to create a new entry stays at the top left as it is now.

@devinreams
Copy link
Contributor

@henryhahn Thanks again for your contributions. I admit we were a bit premature in pushing up concepts that weren't fully baked for implementation (and not obvious online here that was the case).

Going forward we'll explicitly tag "good first issue" to match the GitHub convention. As the project matures we'll have more and more. But for now, we've taken a different user experience approach and this PR no longer applies.

@devinreams devinreams closed this Nov 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants