-
Notifications
You must be signed in to change notification settings - Fork 26
Add landing page create button #337
Add landing page create button #337
Conversation
@@ -18,6 +18,8 @@ welcome-feedback = | |||
button within the tool, including any issues you may find, things | |||
you like, and the things you're looking forward to in the future. | |||
|
|||
welcome-add-item = Create Entry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this string used somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, good catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't where the spec puts the button; according to the spec, it goes in the list on the left. I still need to discuss this a bit more before we make any changes to this area though...
Hey @jimporter - I'm looking at the mocks linked in the bug: https://mozilla.invisionapp.com/share/MHEBCD4PK#/screens/262155636 It does look to me like its meant to happen here below the fold. Do you mind clarifying what you mean? |
Thanks for the contributions thus far, @henryhahn! Right now @changecourse (our UX expert and designer) is re-imaginging some of the flows from "first run" through to "coming back to a welcome screen" (aka landing page) and what those should be to guide the user's experience. Long story short: we have a lot of moving parts and the designs aren't all ready quite yet. We expect some explicit requirements (in the form of a new issue or updates to #292) to come soon to help clearly describe what we want to change. Stay tuned! |
@henryhahn The mockup you linked shows different buttons on the homepage than the one you added. Based on the mockup, we plan to put buttons there to set up a Firefox Account for sync/master password stuff. The button to create a new entry stays at the top left as it is now. |
@henryhahn Thanks again for your contributions. I admit we were a bit premature in pushing up concepts that weren't fully baked for implementation (and not obvious online here that was the case). Going forward we'll explicitly tag "good first issue" to match the GitHub convention. As the project matures we'll have more and more. But for now, we've taken a different user experience approach and this PR no longer applies. |
This PR adds a button to the landing page for being able to directly add a new entry.
This is meant to start implementing the designs associated with #293.